From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39188 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935105AbdAFPJM (ORCPT ); Fri, 6 Jan 2017 10:09:12 -0500 Subject: Patch "IB/cma: Fix a race condition in iboe_addr_get_sgid()" has been added to the 4.9-stable tree To: bart.vanassche@sandisk.com, dledford@redhat.com, gregkh@linuxfoundation.org, monis@mellanox.com, ogerlitz@mellanox.com, roland@purestorage.com Cc: , From: Date: Fri, 06 Jan 2017 16:09:16 +0100 Message-ID: <148371535656208@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled IB/cma: Fix a race condition in iboe_addr_get_sgid() to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ib-cma-fix-a-race-condition-in-iboe_addr_get_sgid.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From fba332b079029c2f4f7e84c1c1cd8e3867310c90 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Mon, 19 Dec 2016 18:00:05 +0100 Subject: IB/cma: Fix a race condition in iboe_addr_get_sgid() From: Bart Van Assche commit fba332b079029c2f4f7e84c1c1cd8e3867310c90 upstream. Code that dereferences the struct net_device ip_ptr member must be protected with an in_dev_get() / in_dev_put() pair. Hence insert calls to these functions. Fixes: commit 7b85627b9f02 ("IB/cma: IBoE (RoCE) IP-based GID addressing") Signed-off-by: Bart Van Assche Reviewed-by: Moni Shoua Cc: Or Gerlitz Cc: Roland Dreier Signed-off-by: Doug Ledford Signed-off-by: Greg Kroah-Hartman --- include/rdma/ib_addr.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/include/rdma/ib_addr.h +++ b/include/rdma/ib_addr.h @@ -205,10 +205,12 @@ static inline void iboe_addr_get_sgid(st dev = dev_get_by_index(&init_net, dev_addr->bound_dev_if); if (dev) { - ip4 = (struct in_device *)dev->ip_ptr; - if (ip4 && ip4->ifa_list && ip4->ifa_list->ifa_address) + ip4 = in_dev_get(dev); + if (ip4 && ip4->ifa_list && ip4->ifa_list->ifa_address) { ipv6_addr_set_v4mapped(ip4->ifa_list->ifa_address, (struct in6_addr *)gid); + in_dev_put(ip4); + } dev_put(dev); } } Patches currently in stable-queue which might be from bart.vanassche@sandisk.com are queue-4.9/ib-mad-fix-an-array-index-check.patch queue-4.9/ipoib-avoid-reading-an-uninitialized-member-variable.patch queue-4.9/ib-rxe-fix-a-memory-leak-in-rxe_qp_cleanup.patch queue-4.9/ib-multicast-check-ib_find_pkey-return-value.patch queue-4.9/ib-cma-fix-a-race-condition-in-iboe_addr_get_sgid.patch queue-4.9/iscsi-target-return-error-if-unable-to-add-network-portal.patch