From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39238 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935155AbdAFPJZ (ORCPT ); Fri, 6 Jan 2017 10:09:25 -0500 Subject: Patch "IPoIB: Avoid reading an uninitialized member variable" has been added to the 4.9-stable tree To: bart.vanassche@sandisk.com, dledford@redhat.com, erezsh@mellanox.com, gregkh@linuxfoundation.org, leonro@mellanox.com Cc: , From: Date: Fri, 06 Jan 2017 16:09:18 +0100 Message-ID: <1483715358109125@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled IPoIB: Avoid reading an uninitialized member variable to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ipoib-avoid-reading-an-uninitialized-member-variable.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 11b642b84e8c43e8597de031678d15c08dd057bc Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Mon, 21 Nov 2016 10:21:41 -0800 Subject: IPoIB: Avoid reading an uninitialized member variable From: Bart Van Assche commit 11b642b84e8c43e8597de031678d15c08dd057bc upstream. This patch avoids that Coverity reports the following: Using uninitialized value port_attr.state when calling printk Fixes: commit 94232d9ce817 ("IPoIB: Start multicast join process only on active ports") Signed-off-by: Bart Van Assche Cc: Erez Shitrit Reviewed-by: Leon Romanovsky Signed-off-by: Doug Ledford Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c @@ -575,8 +575,11 @@ void ipoib_mcast_join_task(struct work_s if (!test_bit(IPOIB_FLAG_OPER_UP, &priv->flags)) return; - if (ib_query_port(priv->ca, priv->port, &port_attr) || - port_attr.state != IB_PORT_ACTIVE) { + if (ib_query_port(priv->ca, priv->port, &port_attr)) { + ipoib_dbg(priv, "ib_query_port() failed\n"); + return; + } + if (port_attr.state != IB_PORT_ACTIVE) { ipoib_dbg(priv, "port state is not ACTIVE (state = %d) suspending join task\n", port_attr.state); return; Patches currently in stable-queue which might be from bart.vanassche@sandisk.com are queue-4.9/ib-mad-fix-an-array-index-check.patch queue-4.9/ipoib-avoid-reading-an-uninitialized-member-variable.patch queue-4.9/ib-rxe-fix-a-memory-leak-in-rxe_qp_cleanup.patch queue-4.9/ib-multicast-check-ib_find_pkey-return-value.patch queue-4.9/ib-cma-fix-a-race-condition-in-iboe_addr_get_sgid.patch queue-4.9/iscsi-target-return-error-if-unable-to-add-network-portal.patch