From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39934 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965375AbdAFPcw (ORCPT ); Fri, 6 Jan 2017 10:32:52 -0500 Subject: Patch "target/user: Fix use-after-free of tcmu_cmds if they are expired" has been added to the 4.8-stable tree To: agrover@redhat.com, bart.vanassche@sandisk.com, bgly@us.ibm.com, gregkh@linuxfoundation.org Cc: , From: Date: Fri, 06 Jan 2017 16:32:21 +0100 Message-ID: <148371674154173@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled target/user: Fix use-after-free of tcmu_cmds if they are expired to the 4.8-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: target-user-fix-use-after-free-of-tcmu_cmds-if-they-are-expired.patch and it can be found in the queue-4.8 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From d0905ca757bc40bd1ebc261a448a521b064777d7 Mon Sep 17 00:00:00 2001 From: Andy Grover Date: Mon, 21 Nov 2016 16:35:30 -0800 Subject: target/user: Fix use-after-free of tcmu_cmds if they are expired From: Andy Grover commit d0905ca757bc40bd1ebc261a448a521b064777d7 upstream. Don't free the cmd in tcmu_check_expired_cmd, it's still referenced by an entry in our cmd_id->cmd idr. If userspace ever resumes processing, tcmu_handle_completions() will use the now-invalid cmd pointer. Instead, don't free cmd. It will be freed by tcmu_handle_completion() if userspace ever recovers, or tcmu_free_device if not. Reported-by: Bryant G Ly Tested-by: Bryant G Ly Signed-off-by: Andy Grover Signed-off-by: Bart Van Assche Signed-off-by: Greg Kroah-Hartman --- drivers/target/target_core_user.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -682,8 +682,6 @@ static int tcmu_check_expired_cmd(int id target_complete_cmd(cmd->se_cmd, SAM_STAT_CHECK_CONDITION); cmd->se_cmd = NULL; - kmem_cache_free(tcmu_cmd_cache, cmd); - return 0; } Patches currently in stable-queue which might be from agrover@redhat.com are queue-4.8/target-user-fix-use-after-free-of-tcmu_cmds-if-they-are-expired.patch