* FAILED: patch "[PATCH] iio: 104-quad-8: Fix index control configuration" failed to apply to 4.9-stable tree
@ 2017-01-09 8:26 gregkh
2017-01-09 13:44 ` William Breathitt Gray
0 siblings, 1 reply; 2+ messages in thread
From: gregkh @ 2017-01-09 8:26 UTC (permalink / raw)
To: vilhelm.gray, Stable, jic23; +Cc: stable
The patch below does not apply to the 4.9-stable tree.
If someone wants it applied there, or to any other stable or longterm
tree, then please email the backport, including the original git commit
id to <stable@vger.kernel.org>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
>From 47af2c676ae1e84140225d261a00bdf88f1f9f7e Mon Sep 17 00:00:00 2001
From: William Breathitt Gray <vilhelm.gray@gmail.com>
Date: Mon, 28 Nov 2016 16:22:44 -0500
Subject: [PATCH] iio: 104-quad-8: Fix index control configuration
The LS7266R1 requires bits 5 & 6 to be high in order to select the Index
Control Register. This patch fixes a typo that incorrectly selects the
Input/Output Control Register where the Index Control Register was
desired.
Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
index 2d2ee353dde7..c0a69d7e9ce7 100644
--- a/drivers/iio/counter/104-quad-8.c
+++ b/drivers/iio/counter/104-quad-8.c
@@ -362,7 +362,7 @@ static int quad8_set_synchronous_mode(struct iio_dev *indio_dev,
priv->synchronous_mode[chan->channel] = synchronous_mode;
/* Load Index Control configuration to Index Control Register */
- outb(0x40 | idr_cfg, base_offset);
+ outb(0x60 | idr_cfg, base_offset);
return 0;
}
@@ -444,7 +444,7 @@ static int quad8_set_index_polarity(struct iio_dev *indio_dev,
priv->index_polarity[chan->channel] = index_polarity;
/* Load Index Control configuration to Index Control Register */
- outb(0x40 | idr_cfg, base_offset);
+ outb(0x60 | idr_cfg, base_offset);
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: FAILED: patch "[PATCH] iio: 104-quad-8: Fix index control configuration" failed to apply to 4.9-stable tree
2017-01-09 8:26 FAILED: patch "[PATCH] iio: 104-quad-8: Fix index control configuration" failed to apply to 4.9-stable tree gregkh
@ 2017-01-09 13:44 ` William Breathitt Gray
0 siblings, 0 replies; 2+ messages in thread
From: William Breathitt Gray @ 2017-01-09 13:44 UTC (permalink / raw)
To: gregkh; +Cc: Stable, jic23
On Mon, Jan 09, 2017 at 09:26:34AM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.9-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
This patch fixes a commit in the current 4.10-rc tree; the relevant
commit is not present in the 4.9-stable tree.
I apologize for the confusion. In the future I'll try to be more
explicit whether fixes should be applied to the stable tree.
William Breathitt Gray
>
>------------------ original commit in Linus's tree ------------------
>
>>From 47af2c676ae1e84140225d261a00bdf88f1f9f7e Mon Sep 17 00:00:00 2001
>From: William Breathitt Gray <vilhelm.gray@gmail.com>
>Date: Mon, 28 Nov 2016 16:22:44 -0500
>Subject: [PATCH] iio: 104-quad-8: Fix index control configuration
>
>The LS7266R1 requires bits 5 & 6 to be high in order to select the Index
>Control Register. This patch fixes a typo that incorrectly selects the
>Input/Output Control Register where the Index Control Register was
>desired.
>
>Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
>Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>Cc: <Stable@vger.kernel.org>
>Signed-off-by: Jonathan Cameron <jic23@kernel.org>
>
>diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
>index 2d2ee353dde7..c0a69d7e9ce7 100644
>--- a/drivers/iio/counter/104-quad-8.c
>+++ b/drivers/iio/counter/104-quad-8.c
>@@ -362,7 +362,7 @@ static int quad8_set_synchronous_mode(struct iio_dev *indio_dev,
> priv->synchronous_mode[chan->channel] = synchronous_mode;
>
> /* Load Index Control configuration to Index Control Register */
>- outb(0x40 | idr_cfg, base_offset);
>+ outb(0x60 | idr_cfg, base_offset);
>
> return 0;
> }
>@@ -444,7 +444,7 @@ static int quad8_set_index_polarity(struct iio_dev *indio_dev,
> priv->index_polarity[chan->channel] = index_polarity;
>
> /* Load Index Control configuration to Index Control Register */
>- outb(0x40 | idr_cfg, base_offset);
>+ outb(0x60 | idr_cfg, base_offset);
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-09 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-09 8:26 FAILED: patch "[PATCH] iio: 104-quad-8: Fix index control configuration" failed to apply to 4.9-stable tree gregkh
2017-01-09 13:44 ` William Breathitt Gray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).