FAILED: patch "[PATCH] iio: 104-quad-8: Fix active level mismatch for the preset" failed to apply to 4.9-stable tree

FAILED: patch "[PATCH] iio: 104-quad-8: Fix active level mismatch for the preset" failed to apply to 4.9-stable tree

[gregkh]

The patch below does not apply to the 4.9-stable tree.
If someone wants it applied there, or to any other stable or longterm
tree, then please email the backport, including the original git commit
id to <stable@vger.kernel.org>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

>From e91c3dfcd3ff88218c972cb24f932c4d434bbb09 Mon Sep 17 00:00:00 2001
From: William Breathitt Gray <vilhelm.gray@gmail.com>
Date: Tue, 29 Nov 2016 10:51:48 -0500
Subject: [PATCH] iio: 104-quad-8: Fix active level mismatch for the preset
 enable option

The set_to_preset_on_index sysfs attribute provides a boolean
configuration option to enable a preset operation on the respective
channel's counter when Index occurs. However, the corresponding
configuration bit on the Input/Output Control register must be set low
to enable the preset operation.

This patch inverts the internal driver boolean logic exposed via the
set_to_preset_on_index attribute in order to correctly configure the
device which expects an active low bit.

Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
index 07b6d20c0756..a5913e97945e 100644
--- a/drivers/iio/counter/104-quad-8.c
+++ b/drivers/iio/counter/104-quad-8.c
@@ -233,7 +233,7 @@ static ssize_t quad8_read_set_to_preset_on_index(struct iio_dev *indio_dev,
 	const struct quad8_iio *const priv = iio_priv(indio_dev);
 
 	return snprintf(buf, PAGE_SIZE, "%u\n",
-		priv->preset_enable[chan->channel]);
+		!priv->preset_enable[chan->channel]);
 }
 
 static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev,
@@ -250,6 +250,9 @@ static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev,
 	if (ret)
 		return ret;
 
+	/* Preset enable is active low in Input/Output Control register */
+	preset_enable = !preset_enable;
+
 	priv->preset_enable[chan->channel] = preset_enable;
 
 	ior_cfg = priv->ab_enable[chan->channel] |

Re: FAILED: patch "[PATCH] iio: 104-quad-8: Fix active level mismatch for the preset" failed to apply to 4.9-stable tree

[William Breathitt Gray]

On Mon, Jan 09, 2017 at 09:27:11AM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.9-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h

This patch fixes a commit in the current 4.10-rc tree; the relevant
commit is not present in the 4.9-stable tree.

I apologize for the confusion. In the future I'll try to be more
explicit whether fixes should be applied to the stable tree.

William Breathitt Gray

>
>------------------ original commit in Linus's tree ------------------
>
>>From e91c3dfcd3ff88218c972cb24f932c4d434bbb09 Mon Sep 17 00:00:00 2001
>From: William Breathitt Gray <vilhelm.gray@gmail.com>
>Date: Tue, 29 Nov 2016 10:51:48 -0500
>Subject: [PATCH] iio: 104-quad-8: Fix active level mismatch for the preset
> enable option
>
>The set_to_preset_on_index sysfs attribute provides a boolean
>configuration option to enable a preset operation on the respective
>channel's counter when Index occurs. However, the corresponding
>configuration bit on the Input/Output Control register must be set low
>to enable the preset operation.
>
>This patch inverts the internal driver boolean logic exposed via the
>set_to_preset_on_index attribute in order to correctly configure the
>device which expects an active low bit.
>
>Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
>Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>Cc: <Stable@vger.kernel.org>
>Signed-off-by: Jonathan Cameron <jic23@kernel.org>
>
>diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
>index 07b6d20c0756..a5913e97945e 100644
>--- a/drivers/iio/counter/104-quad-8.c
>+++ b/drivers/iio/counter/104-quad-8.c
>@@ -233,7 +233,7 @@ static ssize_t quad8_read_set_to_preset_on_index(struct iio_dev *indio_dev,
> 	const struct quad8_iio *const priv = iio_priv(indio_dev);
> 
> 	return snprintf(buf, PAGE_SIZE, "%u\n",
>-		priv->preset_enable[chan->channel]);
>+		!priv->preset_enable[chan->channel]);
> }
> 
> static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev,
>@@ -250,6 +250,9 @@ static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev,
> 	if (ret)
> 		return ret;
> 
>+	/* Preset enable is active low in Input/Output Control register */
>+	preset_enable = !preset_enable;
>+
> 	priv->preset_enable[chan->channel] = preset_enable;
> 
> 	ior_cfg = priv->ab_enable[chan->channel] |
>