From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:44070 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935897AbdAIL13 (ORCPT ); Mon, 9 Jan 2017 06:27:29 -0500 Subject: Patch "stable-fixup: hotplug: fix unused function warning" has been added to the 4.4-stable tree To: arnd@arndb.de, akpm@linux-foundation.org, ddstreet@ieee.org, gregkh@linuxfoundation.org, mhocko@suse.com, tglx@linutronix.de, yuzhao@google.com Cc: , From: Date: Mon, 09 Jan 2017 12:27:49 +0100 In-Reply-To: <20170109104811.1453295-1-arnd@arndb.de> Message-ID: <1483961269219181@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled stable-fixup: hotplug: fix unused function warning to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: stable-fixup-hotplug-fix-unused-function-warning.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From arnd@arndb.de Mon Jan 9 12:26:47 2017 From: Arnd Bergmann Date: Mon, 9 Jan 2017 11:47:50 +0100 Subject: stable-fixup: hotplug: fix unused function warning To: stable@vger.kernel.org, Greg Kroah-Hartman Cc: Thomas Gleixner , Dan Streetman , Andrew Morton , linux-mm@kvack.org, Michal Hocko , Yu Zhao , Arnd Bergmann , linux-kernel@vger.kernel.org Message-ID: <20170109104811.1453295-1-arnd@arndb.de> From: Arnd Bergmann [resolves a messed up backport, so no matching upstream commit] The backport of upstream commit 777c6e0daebb ("hotplug: Make register and unregister notifier API symmetric") to linux-4.4.y introduced a harmless warning in 'allnoconfig' builds as spotted by kernelci.org: kernel/cpu.c:226:13: warning: 'cpu_notify_nofail' defined but not used [-Wunused-function] So far, this is the only stable tree that is affected, as linux-4.6 and higher contain commit 984581728eb4 ("cpu/hotplug: Split out cpu down functions") that makes the function used in all configurations, while older longterm releases so far don't seem to have a backport of 777c6e0daebb. The fix for the warning is trivial: move the unused function back into the #ifdef section where it was before. Link: https://kernelci.org/build/id/586fcacb59b514049ef6c3aa/logs/ Fixes: 1c0f4e0ebb79 ("hotplug: Make register and unregister notifier API symmetric") in v4.4.y Signed-off-by: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman --- kernel/cpu.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -223,10 +223,6 @@ static int cpu_notify(unsigned long val, return __cpu_notify(val, v, -1, NULL); } -static void cpu_notify_nofail(unsigned long val, void *v) -{ - BUG_ON(cpu_notify(val, v)); -} EXPORT_SYMBOL(register_cpu_notifier); EXPORT_SYMBOL(__register_cpu_notifier); @@ -245,6 +241,11 @@ void __unregister_cpu_notifier(struct no EXPORT_SYMBOL(__unregister_cpu_notifier); #ifdef CONFIG_HOTPLUG_CPU +static void cpu_notify_nofail(unsigned long val, void *v) +{ + BUG_ON(cpu_notify(val, v)); +} + /** * clear_tasks_mm_cpumask - Safely clear tasks' mm_cpumask for a CPU * @cpu: a CPU id Patches currently in stable-queue which might be from arnd@arndb.de are queue-4.4/stable-fixup-hotplug-fix-unused-function-warning.patch