From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:60032 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761650AbdAIPEt (ORCPT ); Mon, 9 Jan 2017 10:04:49 -0500 Subject: Patch "target/iscsi: Fix double free in lio_target_tiqn_addtpg()" has been added to the 4.4-stable tree To: dan.carpenter@oracle.com, bart.vanassche@sandisk.com, ddiss@suse.de, gregkh@linuxfoundation.org Cc: , From: Date: Mon, 09 Jan 2017 16:04:28 +0100 Message-ID: <1483974268105171@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled target/iscsi: Fix double free in lio_target_tiqn_addtpg() to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: target-iscsi-fix-double-free-in-lio_target_tiqn_addtpg.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From a91918cd3ea11f91c68e08e1e8ce1b560447a80e Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Tue, 13 Dec 2016 15:27:04 +0300 Subject: target/iscsi: Fix double free in lio_target_tiqn_addtpg() From: Dan Carpenter commit a91918cd3ea11f91c68e08e1e8ce1b560447a80e upstream. This iscsit_tpg_add_portal_group() function is only called from lio_target_tiqn_addtpg(). Both functions free the "tpg" pointer on error so it's a double free bug. The memory is allocated in the caller so it should be freed in the caller and not here. Fixes: e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1") Signed-off-by: Dan Carpenter Reviewed-by: David Disseldorp [ bvanassche: Added "Fix" at start of patch title ] Signed-off-by: Bart Van Assche Signed-off-by: Greg Kroah-Hartman --- drivers/target/iscsi/iscsi_target_tpg.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/target/iscsi/iscsi_target_tpg.c +++ b/drivers/target/iscsi/iscsi_target_tpg.c @@ -260,7 +260,6 @@ err_out: iscsi_release_param_list(tpg->param_list); tpg->param_list = NULL; } - kfree(tpg); return -ENOMEM; } Patches currently in stable-queue which might be from dan.carpenter@oracle.com are queue-4.4/mmc-mmc_test-uninitialized-return-value.patch queue-4.4/target-iscsi-fix-double-free-in-lio_target_tiqn_addtpg.patch queue-4.4/s390-crypto-unlock-on-error-in-prng_tdes_read.patch queue-4.4/usb-xhci-mem-use-passed-in-gfp-flags-instead-of-gfp_kernel.patch queue-4.4/iommu-amd-missing-error-code-in-amd_iommu_init_device.patch