From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34046 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S969985AbdAIPZw (ORCPT ); Mon, 9 Jan 2017 10:25:52 -0500 Subject: Patch "clk: clk-wm831x: fix a logic error" has been added to the 4.9-stable tree To: bianpan2016@163.com, ckeepax@opensource.wolfsonmicro.com, gregkh@linuxfoundation.org, sboyd@codeaurora.org Cc: , From: Date: Mon, 09 Jan 2017 16:26:07 +0100 Message-ID: <1483975567177120@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled clk: clk-wm831x: fix a logic error to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: clk-clk-wm831x-fix-a-logic-error.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 20979202ee6e4c68dab7bcf408787225a656d18e Mon Sep 17 00:00:00 2001 From: Pan Bian Date: Thu, 1 Dec 2016 14:25:44 +0800 Subject: clk: clk-wm831x: fix a logic error From: Pan Bian commit 20979202ee6e4c68dab7bcf408787225a656d18e upstream. Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function wm831x_clkout_is_prepared() returns "true" when it fails to read CLOCK_CONTROL_1. "true" means the device is already prepared. So return "true" on the read failure seems improper. Signed-off-by: Pan Bian Acked-by: Charles Keepax Fixes: f05259a6ffa4 ("clk: wm831x: Add initial WM831x clock driver") Signed-off-by: Stephen Boyd Signed-off-by: Greg Kroah-Hartman --- drivers/clk/clk-wm831x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/clk/clk-wm831x.c +++ b/drivers/clk/clk-wm831x.c @@ -243,7 +243,7 @@ static int wm831x_clkout_is_prepared(str if (ret < 0) { dev_err(wm831x->dev, "Unable to read CLOCK_CONTROL_1: %d\n", ret); - return true; + return false; } return (ret & WM831X_CLKOUT_ENA) != 0; Patches currently in stable-queue which might be from bianpan2016@163.com are queue-4.9/usb-serial-kl5kusb105-abort-on-open-exception-path.patch queue-4.9/clk-clk-wm831x-fix-a-logic-error.patch queue-4.9/usb-return-error-code-when-platform_get_irq-fails.patch