From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:60222 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754231AbdA0Iuc (ORCPT ); Fri, 27 Jan 2017 03:50:32 -0500 Subject: Patch "drm/vc4: Return -EINVAL on the overflow checks failing." has been added to the 4.9-stable tree To: eric@anholt.net, gregkh@linuxfoundation.org, mingo@kernel.org Cc: , From: Date: Fri, 27 Jan 2017 09:49:23 +0100 Message-ID: <14855069633186@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled drm/vc4: Return -EINVAL on the overflow checks failing. to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-vc4-return-einval-on-the-overflow-checks-failing.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 6b8ac63847bc2f958dd93c09edc941a0118992d9 Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Tue, 17 Jan 2017 21:58:06 +1100 Subject: drm/vc4: Return -EINVAL on the overflow checks failing. From: Eric Anholt commit 6b8ac63847bc2f958dd93c09edc941a0118992d9 upstream. By failing to set the errno, we'd continue on to trying to set up the RCL, and then oops on trying to dereference the tile_bo that binning validation should have set up. Reported-by: Ingo Molnar Signed-off-by: Eric Anholt Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.") Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/vc4/vc4_gem.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpu/drm/vc4/vc4_gem.c +++ b/drivers/gpu/drm/vc4/vc4_gem.c @@ -601,6 +601,7 @@ vc4_get_bcl(struct drm_device *dev, stru sizeof(struct vc4_shader_state)) || temp_size < exec_size) { DRM_ERROR("overflow in exec arguments\n"); + ret = -EINVAL; goto fail; } Patches currently in stable-queue which might be from eric@anholt.net are queue-4.9/drm-vc4-return-einval-on-the-overflow-checks-failing.patch queue-4.9/drm-vc4-fix-memory-leak-of-the-crtc-state.patch queue-4.9/drm-vc4-fix-an-integer-overflow-in-temporary-allocation-layout.patch queue-4.9/drm-vc4-fix-a-bounds-check.patch