stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "HID: cp2112: fix gpio-callback error handling" has been added to the 4.9-stable tree
@ 2017-02-04  9:16 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-02-04  9:16 UTC (permalink / raw)
  To: johan, benjamin.tissoires, gregkh, jkosina; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    HID: cp2112: fix gpio-callback error handling

to the 4.9-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     hid-cp2112-fix-gpio-callback-error-handling.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 8e9faa15469ed7c7467423db4c62aeed3ff4cae3 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Mon, 30 Jan 2017 11:26:39 +0100
Subject: HID: cp2112: fix gpio-callback error handling

From: Johan Hovold <johan@kernel.org>

commit 8e9faa15469ed7c7467423db4c62aeed3ff4cae3 upstream.

In case of a zero-length report, the gpio direction_input callback would
currently return success instead of an errno.

Fixes: 1ffb3c40ffb5 ("HID: cp2112: make transfer buffers DMA capable")
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/hid/hid-cp2112.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/hid/hid-cp2112.c
+++ b/drivers/hid/hid-cp2112.c
@@ -206,7 +206,7 @@ static int cp2112_gpio_direction_input(s
 
 exit:
 	mutex_unlock(&dev->lock);
-	return ret <= 0 ? ret : -EIO;
+	return ret < 0 ? ret : -EIO;
 }
 
 static void cp2112_gpio_set(struct gpio_chip *chip, unsigned offset, int value)


Patches currently in stable-queue which might be from johan@kernel.org are

queue-4.9/hid-cp2112-fix-gpio-callback-error-handling.patch
queue-4.9/hid-cp2112-fix-sleep-while-atomic.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-02-04  9:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-04  9:16 Patch "HID: cp2112: fix gpio-callback error handling" has been added to the 4.9-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).