From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from bedivere.hansenpartnership.com ([66.63.167.143]:57054 "EHLO
        bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1755359AbdBGRCx (ORCPT
        <rfc822;stable@vger.kernel.org>); Tue, 7 Feb 2017 12:02:53 -0500
Message-ID: <1486486971.2488.19.camel@HansenPartnership.com>
Subject: Re: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature
 termination
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        linux@roeck-us.net, Andrey Grodzovsky <andrey2805@gmail.com>,
        linux-scsi@vger.kernel.org,
        Chaitra Basappa <chaitra.basappa@broadcom.com>,
        Suganath Prabu Subramani
        <suganath-prabu.subramani@broadcom.com>,
        Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
        Hannes Reinecke <hare@suse.de>,
        "Martin K . Petersen" <martin.petersen@oracle.com>
Date: Tue, 07 Feb 2017 09:02:51 -0800
In-Reply-To: <20170207065946.GC4850@1wt.eu>
References: <1486322541-8206-1-git-send-email-w@1wt.eu>
         <1486322541-8206-42-git-send-email-w@1wt.eu>
         <ae8ffc4f86c5af1caf97dfa9a6493443@mail.gmail.com>
         <20170206222623.GA4769@1wt.eu>
         <1486449528.2474.125.camel@HansenPartnership.com>
         <20170207065946.GC4850@1wt.eu>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Tue, 2017-02-07 at 07:59 +0100, Willy Tarreau wrote:
> Hi James,
> 
> On Mon, Feb 06, 2017 at 10:38:48PM -0800, James Bottomley wrote:
> > On Mon, 2017-02-06 at 23:26 +0100, Willy Tarreau wrote:
> (...)
> > > We don't have the referenced commit above in 3.10 so we should be
> > > safe. Additionally I checked that neither 4.4 nor 3.12 have them 
> > > either, so that makes me feel confident that we can skip it in 
> > > 3.10 as well.
> > 
> > The original was also racy with respect to multiple commands, so 
> > the above fixed the race as well.
> 
> OK so I tried to backport it to 3.10. I dropped a few parts which 
> were addressing this one marked for stable 4.4+ :
>     7ff723a ("scsi: mpt3sas: Unblock device after controller reset")
> 
> And I got the attached patch. All I know is that it builds. I'd 
> appreciate it if someone could confirm its validity, in which case
> I'll add it.

The two patches apply without fuzz to your tree and the combination is
a far better bug fix than the original regardless of whether 7ff723a
exists in your tree or not.  By messing with the patches all you do is
add the potential for introducing new bugs for no benefit, so why take
risk for no upside?

James