From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:16411 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755560AbdCGSCq (ORCPT ); Tue, 7 Mar 2017 13:02:46 -0500 Message-ID: <1488908849.5130.9.camel@linux.intel.com> Subject: Re: [PATCH v3] drm/i915: Store a permanent error in obj->mm.pages From: Joonas Lahtinen To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: "# v4 . 10+" Date: Tue, 07 Mar 2017 19:47:29 +0200 In-Reply-To: <20170307132031.32461-1-chris@chris-wilson.co.uk> References: <20170307120338.7277-1-chris@chris-wilson.co.uk> <20170307132031.32461-1-chris@chris-wilson.co.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On ti, 2017-03-07 at 13:20 +0000, Chris Wilson wrote: > Once the object has been truncated, it is unrecoverable. To facilitate > detection of this state store the error in obj->mm.pages. > > This is required for the next patch which should be applied to v4.10 > (via stable), so we also need to mark this patch for backporting. In > that regard, let's consider this to be a fix/improvement too. > > v2: Avoid dereferencing the ERR_PTR when freeing the object. > > Fixes: 1233e2db199d ("drm/i915: Move object backing storage manipulation to its own locking") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: # v4.10+ I'd imagine we may want a couple more GEM_BUG_ON checks going forward. Regardless; Reviewed-by: Joonas Lahtinen Regards, Joonas --  Joonas Lahtinen Open Source Technology Center Intel Corporation