stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "w1: don't leak refcount on slave attach failure in w1_attach_slave_device()" has been added to the 4.4-stable tree
@ 2017-03-10  8:33 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-03-10  8:33 UTC (permalink / raw)
  To: mail, gregkh, zbr; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    w1: don't leak refcount on slave attach failure in w1_attach_slave_device()

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     w1-don-t-leak-refcount-on-slave-attach-failure-in-w1_attach_slave_device.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From d2ce4ea1a0b0162e5d2d7e7942ab6f5cc2063d5a Mon Sep 17 00:00:00 2001
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Date: Sat, 21 Jan 2017 23:50:18 +0100
Subject: w1: don't leak refcount on slave attach failure in w1_attach_slave_device()

From: Maciej S. Szmigiero <mail@maciej.szmigiero.name>

commit d2ce4ea1a0b0162e5d2d7e7942ab6f5cc2063d5a upstream.

Near the beginning of w1_attach_slave_device() we increment a w1 master
reference count.
Later, when we are going to exit this function without actually attaching
a slave device (due to failure of __w1_attach_slave_device()) we need to
decrement this reference count back.

Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Fixes: 9fcbbac5ded489 ("w1: process w1 netlink commands in w1_process thread")
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/w1/w1.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -763,6 +763,7 @@ int w1_attach_slave_device(struct w1_mas
 		dev_err(&dev->dev, "%s: Attaching %s failed.\n", __func__,
 			 sl->name);
 		w1_family_put(sl->family);
+		atomic_dec(&sl->master->refcnt);
 		kfree(sl);
 		return err;
 	}


Patches currently in stable-queue which might be from mail@maciej.szmigiero.name are

queue-4.4/w1-don-t-leak-refcount-on-slave-attach-failure-in-w1_attach_slave_device.patch
queue-4.4/w1-ds2490-usb-transfer-buffers-need-to-be-dmaable.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-03-10  8:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-10  8:33 Patch "w1: don't leak refcount on slave attach failure in w1_attach_slave_device()" has been added to the 4.4-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).