stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "USB: uss720: fix NULL-deref at probe" has been added to the 4.4-stable tree
@ 2017-03-27 16:38 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-03-27 16:38 UTC (permalink / raw)
  To: johan, gregkh; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    USB: uss720: fix NULL-deref at probe

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     usb-uss720-fix-null-deref-at-probe.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From f259ca3eed6e4b79ac3d5c5c9fb259fb46e86217 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Mon, 13 Mar 2017 13:47:50 +0100
Subject: USB: uss720: fix NULL-deref at probe

From: Johan Hovold <johan@kernel.org>

commit f259ca3eed6e4b79ac3d5c5c9fb259fb46e86217 upstream.

Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer or accessing memory beyond the endpoint array should a
malicious device lack the expected endpoints.

Note that the endpoint access that causes the NULL-deref is currently
only used for debugging purposes during probe so the oops only happens
when dynamic debugging is enabled. This means the driver could be
rewritten to continue to accept device with only two endpoints, should
such devices exist.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/misc/uss720.c |    5 +++++
 1 file changed, 5 insertions(+)

--- a/drivers/usb/misc/uss720.c
+++ b/drivers/usb/misc/uss720.c
@@ -711,6 +711,11 @@ static int uss720_probe(struct usb_inter
 
 	interface = intf->cur_altsetting;
 
+	if (interface->desc.bNumEndpoints < 3) {
+		usb_put_dev(usbdev);
+		return -ENODEV;
+	}
+
 	/*
 	 * Allocate parport interface 
 	 */


Patches currently in stable-queue which might be from johan@kernel.org are

queue-4.4/usb-serial-option-add-quectel-uc15-uc20-ec21-and-ec25-modems.patch
queue-4.4/input-ims-pcu-validate-number-of-endpoints-before-using-them.patch
queue-4.4/input-cm109-validate-number-of-endpoints-before-using-them.patch
queue-4.4/input-iforce-validate-number-of-endpoints-before-using-them.patch
queue-4.4/mmc-ushc-fix-null-deref-at-probe.patch
queue-4.4/input-kbtab-validate-number-of-endpoints-before-using-them.patch
queue-4.4/input-sur40-validate-number-of-endpoints-before-using-them.patch
queue-4.4/uwb-i1480-dfu-fix-null-deref-at-probe.patch
queue-4.4/input-hanwang-validate-number-of-endpoints-before-using-them.patch
queue-4.4/usb-idmouse-fix-null-deref-at-probe.patch
queue-4.4/uwb-hwa-rc-fix-null-deref-at-probe.patch
queue-4.4/usb-lvtest-fix-null-deref-at-probe.patch
queue-4.4/input-yealink-validate-number-of-endpoints-before-using-them.patch
queue-4.4/usb-serial-qcserial-add-dell-dw5811e.patch
queue-4.4/usb-uss720-fix-null-deref-at-probe.patch
queue-4.4/usb-wusbcore-fix-null-deref-at-probe.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-03-27 16:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-27 16:38 Patch "USB: uss720: fix NULL-deref at probe" has been added to the 4.4-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).