Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: "Michał Winiarski" <michal.winiarski@intel.com>,
	"# v4 . 10+" <stable@vger.kernel.org>
Subject: Re: [PATCH] drm/i915: Use a dummy timeline name for a signaled fence
Date: Thu, 30 Mar 2017 14:30:12 +0300	[thread overview]
Message-ID: <1490873412.3067.4.camel@linux.intel.com> (raw)
In-Reply-To: <20170330111905.GF1895@nuc-i3427.alporthouse.com>

On to, 2017-03-30 at 12:19 +0100, Chris Wilson wrote:
> On Thu, Mar 30, 2017 at 12:16:14PM +0100, Chris Wilson wrote:
> > 
> > Michał Winiarski pointed out that the debugging infrastructure (such as
> > trace_dma_fence_release) likes to pretty print the timeline name, long
> > after we have freed the timeline. Our timelines currently live as part of
> > the GTT (due to the strict ordering we current use through each) which
> s/current/currently/
> 
> > 
> > belong to the context. We aim to free the context and release its
> > hardware resources as soon as we able to (i.e. when the last
> > fence/request using it has been signaled and retired). As the
> > .get_timeline_name is purely a debug feature, rather than extending the
> > lifetime of the context, or splitting it into many different release
> > phases just to keep the name along, replace the timeline name with a
> s/along/around/
> 
> > 
> > constant after the fence has been signaled. This avoids the potential
> > use-after-free.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation

  reply	other threads:[~2017-03-30 11:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30 11:16 [PATCH] drm/i915: Use a dummy timeline name for a signaled fence Chris Wilson
2017-03-30 11:19 ` Chris Wilson
2017-03-30 11:30   ` Joonas Lahtinen [this message]
2017-03-30 11:50 ` Michał Winiarski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490873412.3067.4.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michal.winiarski@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox