* Patch "staging: android: ashmem: lseek failed due to no FMODE_LSEEK." has been added to the 4.10-stable tree
@ 2017-04-09 19:25 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-04-09 19:25 UTC (permalink / raw)
To: zhangshuxiao, ghackmann, gregkh; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
staging: android: ashmem: lseek failed due to no FMODE_LSEEK.
to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
staging-android-ashmem-lseek-failed-due-to-no-fmode_lseek.patch
and it can be found in the queue-4.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 97fbfef6bd597888485b653175fb846c6998b60c Mon Sep 17 00:00:00 2001
From: Shuxiao Zhang <zhangshuxiao@xiaomi.com>
Date: Thu, 6 Apr 2017 22:30:29 +0800
Subject: staging: android: ashmem: lseek failed due to no FMODE_LSEEK.
From: Shuxiao Zhang <zhangshuxiao@xiaomi.com>
commit 97fbfef6bd597888485b653175fb846c6998b60c upstream.
vfs_llseek will check whether the file mode has
FMODE_LSEEK, no return failure. But ashmem can be
lseek, so add FMODE_LSEEK to ashmem file.
Comment From Greg Hackmann:
ashmem_llseek() passes the llseek() call through to the backing
shmem file. 91360b02ab48 ("ashmem: use vfs_llseek()") changed
this from directly calling the file's llseek() op into a VFS
layer call. This also adds a check for the FMODE_LSEEK bit, so
without that bit ashmem_llseek() now always fails with -ESPIPE.
Fixes: 91360b02ab48 ("ashmem: use vfs_llseek()")
Signed-off-by: Shuxiao Zhang <zhangshuxiao@xiaomi.com>
Tested-by: Greg Hackmann <ghackmann@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/staging/android/ashmem.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -409,6 +409,7 @@ static int ashmem_mmap(struct file *file
ret = PTR_ERR(vmfile);
goto out;
}
+ vmfile->f_mode |= FMODE_LSEEK;
asma->file = vmfile;
}
get_file(asma->file);
Patches currently in stable-queue which might be from zhangshuxiao@xiaomi.com are
queue-4.10/staging-android-ashmem-lseek-failed-due-to-no-fmode_lseek.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-04-09 19:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-09 19:25 Patch "staging: android: ashmem: lseek failed due to no FMODE_LSEEK." has been added to the 4.10-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).