stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch" has been added to the 4.10-stable tree
@ 2017-04-12 13:48 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-04-12 13:48 UTC (permalink / raw)
  To: matt.redfearn, amit.pundir, gregkh, james.hogan, paul.burton,
	ralf
  Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch

to the 4.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     mips-irq-stack-fix-erroneous-jal-to-plat_irq_dispatch.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From c25f8064c1d5731a2ce5664def890140dcdd3e5c Mon Sep 17 00:00:00 2001
From: Matt Redfearn <matt.redfearn@imgtec.com>
Date: Wed, 25 Jan 2017 17:00:25 +0000
Subject: MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch

From: Matt Redfearn <matt.redfearn@imgtec.com>

commit c25f8064c1d5731a2ce5664def890140dcdd3e5c upstream.

Commit dda45f701c9d ("MIPS: Switch to the irq_stack in interrupts")
changed both the normal and vectored interrupt handlers. Unfortunately
the vectored version, "except_vec_vi_handler", was incorrectly modified
to unconditionally jal to plat_irq_dispatch, rather than doing a jalr to
the vectored handler that has been set up. This is ok for many platforms
which set the vectored handler to plat_irq_dispatch anyway, but will
cause problems with platforms that use other handlers.

Fixes: dda45f701c9d ("MIPS: Switch to the irq_stack in interrupts")
Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/15110/
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 arch/mips/kernel/genex.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/mips/kernel/genex.S
+++ b/arch/mips/kernel/genex.S
@@ -329,7 +329,7 @@ NESTED(except_vec_vi_handler, 0, sp)
 	PTR_ADD sp, t0, t1
 
 2:
-	jal	plat_irq_dispatch
+	jalr	v0
 
 	/* Restore sp */
 	move	sp, s1


Patches currently in stable-queue which might be from matt.redfearn@imgtec.com are

queue-4.10/mips-switch-to-the-irq_stack-in-interrupts.patch
queue-4.10/mips-select-have_irq_exit_on_irq_stack.patch
queue-4.10/mips-only-change-28-to-thread_info-if-coming-from-user-mode.patch
queue-4.10/mips-stack-unwinding-while-on-irq-stack.patch
queue-4.10/mips-irq-stack-fix-erroneous-jal-to-plat_irq_dispatch.patch
queue-4.10/mips-introduce-irq_stack.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-04-12 13:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-12 13:48 Patch "MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch" has been added to the 4.10-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).