From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39246 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033985AbdDVF3Y (ORCPT ); Sat, 22 Apr 2017 01:29:24 -0400 Subject: Patch "KEYS: Change the name of the dead type to ".dead" to prevent user access" has been added to the 3.18-stable tree To: dhowells@redhat.com, gregkh@linuxfoundation.org Cc: , From: Date: Sat, 22 Apr 2017 07:29:09 +0200 Message-ID: <149283894953216@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled KEYS: Change the name of the dead type to ".dead" to prevent user access to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: keys-change-the-name-of-the-dead-type-to-.dead-to-prevent-user-access.patch and it can be found in the queue-3.18 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From c1644fe041ebaf6519f6809146a77c3ead9193af Mon Sep 17 00:00:00 2001 From: David Howells Date: Tue, 18 Apr 2017 15:31:08 +0100 Subject: KEYS: Change the name of the dead type to ".dead" to prevent user access From: David Howells commit c1644fe041ebaf6519f6809146a77c3ead9193af upstream. This fixes CVE-2017-6951. Userspace should not be able to do things with the "dead" key type as it doesn't have some of the helper functions set upon it that the kernel needs. Attempting to use it may cause the kernel to crash. Fix this by changing the name of the type to ".dead" so that it's rejected up front on userspace syscalls by key_get_type_from_user(). Though this doesn't seem to affect recent kernels, it does affect older ones, certainly those prior to: commit c06cfb08b88dfbe13be44a69ae2fdc3a7c902d81 Author: David Howells Date: Tue Sep 16 17:36:06 2014 +0100 KEYS: Remove key_type::match in favour of overriding default by match_preparse which went in before 3.18-rc1. Signed-off-by: David Howells Signed-off-by: Greg Kroah-Hartman --- security/keys/gc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/security/keys/gc.c +++ b/security/keys/gc.c @@ -46,7 +46,7 @@ static unsigned long key_gc_flags; * immediately unlinked. */ struct key_type key_type_dead = { - .name = "dead", + .name = ".dead", }; /* Patches currently in stable-queue which might be from dhowells@redhat.com are queue-3.18/keys-disallow-keyrings-beginning-with-.-to-be-joined-as-session-keyrings.patch queue-3.18/keys-change-the-name-of-the-dead-type-to-.dead-to-prevent-user-access.patch queue-3.18/keys-fix-keyctl_set_reqkey_keyring-to-not-leak-thread-keyrings.patch