stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "ipv6: sr: fix double free of skb after handling invalid SRH" has been added to the 4.10-stable tree
@ 2017-04-29  6:23 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-04-29  6:23 UTC (permalink / raw)
  To: david.lebrun, dan.carpenter, davem, gregkh; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    ipv6: sr: fix double free of skb after handling invalid SRH

to the 4.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ipv6-sr-fix-double-free-of-skb-after-handling-invalid-srh.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Sat Apr 29 08:22:40 CEST 2017
From: David Lebrun <david.lebrun@uclouvain.be>
Date: Wed, 19 Apr 2017 16:10:19 +0200
Subject: ipv6: sr: fix double free of skb after handling invalid SRH

From: David Lebrun <david.lebrun@uclouvain.be>


[ Upstream commit 95b9b88d2da5e43e025400afcb492643933bf858 ]

The icmpv6_param_prob() function already does a kfree_skb(),
this patch removes the duplicate one.

Fixes: 1ababeba4a21f3dba3da3523c670b207fb2feb62 ("ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Lebrun <david.lebrun@uclouvain.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 net/ipv6/exthdrs.c |    1 -
 1 file changed, 1 deletion(-)

--- a/net/ipv6/exthdrs.c
+++ b/net/ipv6/exthdrs.c
@@ -388,7 +388,6 @@ looped_back:
 		icmpv6_param_prob(skb, ICMPV6_HDR_FIELD,
 				  ((&hdr->segments_left) -
 				   skb_network_header(skb)));
-		kfree_skb(skb);
 		return -1;
 	}
 


Patches currently in stable-queue which might be from david.lebrun@uclouvain.be are

queue-4.10/ipv6-sr-fix-double-free-of-skb-after-handling-invalid-srh.patch
queue-4.10/ipv6-sr-fix-out-of-bounds-access-in-srh-validation.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-04-29  6:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-29  6:23 Patch "ipv6: sr: fix double free of skb after handling invalid SRH" has been added to the 4.10-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).