From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:57734 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968608AbdD3OWv (ORCPT ); Sun, 30 Apr 2017 10:22:51 -0400 Subject: Patch "sctp: listen on the sock only when it's state is listening or closed" has been added to the 4.4-stable tree To: lucien.xin@gmail.com, andreyknvl@google.com, davem@davemloft.net, gregkh@linuxfoundation.org, marcelo.leitner@gmail.com Cc: , From: Date: Sun, 30 Apr 2017 16:11:40 +0200 Message-ID: <149356150026193@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled sctp: listen on the sock only when it's state is listening or closed to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: sctp-listen-on-the-sock-only-when-it-s-state-is-listening-or-closed.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From foo@baz Sun Apr 30 15:46:17 CEST 2017 From: Xin Long Date: Thu, 6 Apr 2017 13:10:52 +0800 Subject: sctp: listen on the sock only when it's state is listening or closed From: Xin Long [ Upstream commit 34b2789f1d9bf8dcca9b5cb553d076ca2cd898ee ] Now sctp doesn't check sock's state before listening on it. It could even cause changing a sock with any state to become a listening sock when doing sctp_listen. This patch is to fix it by checking sock's state in sctp_listen, so that it will listen on the sock with right state. Reported-by: Andrey Konovalov Tested-by: Andrey Konovalov Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sctp/socket.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -6394,6 +6394,9 @@ int sctp_inet_listen(struct socket *sock if (sock->state != SS_UNCONNECTED) goto out; + if (!sctp_sstate(sk, LISTENING) && !sctp_sstate(sk, CLOSED)) + goto out; + /* If backlog is zero, disable listening. */ if (!backlog) { if (sctp_sstate(sk, CLOSED)) Patches currently in stable-queue which might be from lucien.xin@gmail.com are queue-4.4/sctp-listen-on-the-sock-only-when-it-s-state-is-listening-or-closed.patch