* Patch "iwlwifi: mvm: properly check for transport data in dump" has been added to the 4.10-stable tree
@ 2017-05-09 9:19 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-05-09 9:19 UTC (permalink / raw)
To: johannes.berg, gregkh, luciano.coelho; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
iwlwifi: mvm: properly check for transport data in dump
to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
iwlwifi-mvm-properly-check-for-transport-data-in-dump.patch
and it can be found in the queue-4.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From c2e27e16f2411155b906db201b7e478144034ffe Mon Sep 17 00:00:00 2001
From: Johannes Berg <johannes.berg@intel.com>
Date: Thu, 20 Oct 2016 15:25:00 +0200
Subject: iwlwifi: mvm: properly check for transport data in dump
From: Johannes Berg <johannes.berg@intel.com>
commit c2e27e16f2411155b906db201b7e478144034ffe upstream.
When copying from vmalloc'ed memory to the SG list, don't crash
if the transport didn't provide any data.
Fixes: 7e62a699aafb ("iwlwifi: mvm: use dev_coredumpsg()")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c
@@ -816,11 +816,12 @@ dump_trans_data:
sg_nents(sg_dump_data),
fw_error_dump->op_mode_ptr,
fw_error_dump->op_mode_len, 0);
- sg_pcopy_from_buffer(sg_dump_data,
- sg_nents(sg_dump_data),
- fw_error_dump->trans_ptr->data,
- fw_error_dump->trans_ptr->len,
- fw_error_dump->op_mode_len);
+ if (fw_error_dump->trans_ptr)
+ sg_pcopy_from_buffer(sg_dump_data,
+ sg_nents(sg_dump_data),
+ fw_error_dump->trans_ptr->data,
+ fw_error_dump->trans_ptr->len,
+ fw_error_dump->op_mode_len);
dev_coredumpsg(mvm->trans->dev, sg_dump_data, file_len,
GFP_KERNEL);
}
Patches currently in stable-queue which might be from johannes.berg@intel.com are
queue-4.10/iwlwifi-mvm-properly-check-for-transport-data-in-dump.patch
queue-4.10/iwlwifi-mvm-overwrite-skb-info-later.patch
queue-4.10/iwlwifi-mvm-pcie-adjust-a-msdu-tx_cmd-length-in-pcie.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-05-09 9:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-09 9:19 Patch "iwlwifi: mvm: properly check for transport data in dump" has been added to the 4.10-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).