From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "bp@alien8.de" <bp@alien8.de>
Cc: "Luck, Tony" <tony.luck@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86/MCE: Export memory_error()
Date: Wed, 10 May 2017 22:03:42 +0000 [thread overview]
Message-ID: <1494453738.20330.8.camel@intel.com> (raw)
In-Reply-To: <20170510215707.v7zywrslma4o7jao@pd.tnic>
On Wed, 2017-05-10 at 23:57 +0200, Borislav Petkov wrote:
> On Wed, May 10, 2017 at 09:12:12PM +0000, Verma, Vishal L wrote:
> > The memory error check in the nfit handler is a valid, and simple
> > fix.
>
> I need the big picture here: "Without this fix, the nfit handler ...".
..will potentially add bogus address to an 'error list', even when there
may not have been a memory error. (can mce->addr have an address when
the mce is not due to a memory error?)
The result of adding an address to this list is that future accesses to
this location will prematurely error out. Depending on how frequently
machine checks happen that are not memory errors but have the addr field
set (hopefully rare anyway), we could be incorrectly marking a lot of
locations as media errors.
>
> Then, if the stable rules apply, we can always expedite it through
> urgent/stable.
>
next prev parent reply other threads:[~2017-05-10 22:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 22:18 [PATCH] acpi, nfit: fix the memory error check in nfit_handle_mce Vishal Verma
2017-04-20 22:21 ` Verma, Vishal L
2017-04-21 2:21 ` kbuild test robot
2017-04-21 19:21 ` Dan Williams
2017-04-21 19:56 ` Verma, Vishal L
2017-04-21 20:16 ` Luck, Tony
2017-04-21 20:19 ` Dan Williams
2017-04-21 20:27 ` Luck, Tony
2017-04-21 21:07 ` Borislav Petkov
2017-04-24 11:36 ` [PATCH 1/2] x86/MCE: Export memory_error() Borislav Petkov
2017-04-25 21:07 ` Vishal Verma
2017-05-10 19:31 ` Verma, Vishal L
2017-05-10 20:04 ` Borislav Petkov
2017-05-10 20:06 ` Verma, Vishal L
2017-05-10 20:08 ` Borislav Petkov
2017-05-10 21:12 ` Verma, Vishal L
2017-05-10 21:57 ` Borislav Petkov
2017-05-10 22:03 ` Verma, Vishal L [this message]
2017-05-10 22:16 ` Borislav Petkov
2017-05-10 22:22 ` Verma, Vishal L
2017-05-17 12:38 ` Borislav Petkov
2017-05-17 18:58 ` Verma, Vishal L
2017-05-17 19:20 ` Borislav Petkov
2017-04-24 11:37 ` [PATCH 2/2] x86/ras/mce_amd_inj: Preset MCE injection struct Borislav Petkov
2017-04-26 19:59 ` kbuild test robot
2017-04-21 20:35 ` [PATCH] acpi, nfit: fix the memory error check in nfit_handle_mce Vishal Verma
2017-04-21 20:50 ` Luck, Tony
2017-04-21 20:54 ` Vishal Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494453738.20330.8.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=bp@alien8.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).