From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from imap0.codethink.co.uk ([185.43.218.159]:40366 "EHLO
        imap0.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751424AbdELLgX (ORCPT
        <rfc822;stable@vger.kernel.org>); Fri, 12 May 2017 07:36:23 -0400
Message-ID: <1494588973.3965.68.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in
 clariion_std_inquiry()
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Hannes Reinecke <hare@suse.de>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Date: Fri, 12 May 2017 12:36:13 +0100
In-Reply-To: <20170511141238.883852220@linuxfoundation.org>
References: <20170511141237.094835992@linuxfoundation.org>
         <20170511141238.883852220@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, 2017-05-11 at 16:13 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Dan Carpenter <dan.carpenter@oracle.com>
> 
> commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b upstream.
> 
> We accidentally return an uninitialized variable on success.

No we don't.

> Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler")

Actually fixes: b78205c93297 ("scsi_dh_emc: switch to
scsi_execute_req_flags()") so this is only needed for 4.11.y.

Ben.

> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> ---
>  drivers/scsi/device_handler/scsi_dh_emc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/scsi/device_handler/scsi_dh_emc.c
> +++ b/drivers/scsi/device_handler/scsi_dh_emc.c
> @@ -456,7 +456,7 @@ static int clariion_prep_fn(struct scsi_
>  static int clariion_std_inquiry(struct scsi_device *sdev,
>  				struct clariion_dh_data *csdev)
>  {
> -	int err;
> +	int err = SCSI_DH_OK;
>  	char *sp_model;
>  
>  	err = send_inquiry_cmd(sdev, 0, csdev);
> 
> 
> 

-- 
Ben Hutchings
Software Developer, Codethink Ltd.