From: <gregkh@linuxfoundation.org>
To: ddiss@suse.de, gregkh@linuxfoundation.org, smfrench@gmail.com
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "cifs: fix leak in FSCTL_ENUM_SNAPS response handling" has been added to the 4.9-stable tree
Date: Wed, 17 May 2017 17:56:55 +0200 [thread overview]
Message-ID: <149503661519286@kroah.com> (raw)
This is a note to let you know that I've just added the patch titled
cifs: fix leak in FSCTL_ENUM_SNAPS response handling
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
cifs-fix-leak-in-fsctl_enum_snaps-response-handling.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 0e5c795592930d51fd30d53a2e7b73cba022a29b Mon Sep 17 00:00:00 2001
From: David Disseldorp <ddiss@suse.de>
Date: Wed, 3 May 2017 17:39:09 +0200
Subject: cifs: fix leak in FSCTL_ENUM_SNAPS response handling
From: David Disseldorp <ddiss@suse.de>
commit 0e5c795592930d51fd30d53a2e7b73cba022a29b upstream.
The server may respond with success, and an output buffer less than
sizeof(struct smb_snapshot_array) in length. Do not leak the output
buffer in this case.
Fixes: 834170c85978 ("Enable previous version support")
Signed-off-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Steve French <smfrench@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
fs/cifs/smb2ops.c | 1 +
1 file changed, 1 insertion(+)
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -924,6 +924,7 @@ smb3_enum_snapshots(const unsigned int x
}
if (snapshot_in.snapshot_array_size < sizeof(struct smb_snapshot_array)) {
rc = -ERANGE;
+ kfree(retbuf);
return rc;
}
Patches currently in stable-queue which might be from ddiss@suse.de are
queue-4.9/cifs-fix-cifs_ioc_get_mnt_info-oops.patch
queue-4.9/target-fileio-fix-zero-length-read-and-write-handling.patch
queue-4.9/cifs-fix-cifs_enumerate_snapshots-oops.patch
queue-4.9/cifs-fix-leak-in-fsctl_enum_snaps-response-handling.patch
reply other threads:[~2017-05-17 15:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149503661519286@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ddiss@suse.de \
--cc=smfrench@gmail.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).