From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:37154 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754468AbdEQP7g (ORCPT ); Wed, 17 May 2017 11:59:36 -0400 Subject: Patch "orangefs: do not check possibly stale size on truncate" has been added to the 4.9-stable tree To: martin@omnibond.com, gregkh@linuxfoundation.org, hubcap@omnibond.com Cc: , From: Date: Wed, 17 May 2017 17:57:09 +0200 Message-ID: <14950366292794@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled orangefs: do not check possibly stale size on truncate to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: orangefs-do-not-check-possibly-stale-size-on-truncate.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 53950ef541675df48c219a8d665111a0e68dfc2f Mon Sep 17 00:00:00 2001 From: Martin Brandenburg Date: Tue, 25 Apr 2017 15:38:04 -0400 Subject: orangefs: do not check possibly stale size on truncate From: Martin Brandenburg commit 53950ef541675df48c219a8d665111a0e68dfc2f upstream. Let the server figure this out because our size might be out of date or not present. The bug was that xfs_io -f -t -c "pread -v 0 100" /mnt/foo echo "Test" > /mnt/foo xfs_io -f -t -c "pread -v 0 100" /mnt/foo fails because the second truncate did not happen if nothing had requested the size after the write in echo. Thus i_size was zero (not present) and the orangefs_setattr though i_size was zero and there was nothing to do. Signed-off-by: Martin Brandenburg Signed-off-by: Mike Marshall Signed-off-by: Greg Kroah-Hartman --- fs/orangefs/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/fs/orangefs/inode.c +++ b/fs/orangefs/inode.c @@ -223,8 +223,7 @@ int orangefs_setattr(struct dentry *dent if (ret) goto out; - if ((iattr->ia_valid & ATTR_SIZE) && - iattr->ia_size != i_size_read(inode)) { + if (iattr->ia_valid & ATTR_SIZE) { ret = orangefs_setattr_size(inode, iattr); if (ret) goto out; Patches currently in stable-queue which might be from martin@omnibond.com are queue-4.9/orangefs-do-not-check-possibly-stale-size-on-truncate.patch queue-4.9/orangefs-fix-bounds-check-for-listxattr.patch queue-4.9/orangefs-clean-up-oversize-xattr-validation.patch queue-4.9/orangefs-do-not-set-getattr_time-on-orangefs_lookup.patch