stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()" has been added to the 4.11-stable tree
@ 2017-05-22 17:03 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-05-22 17:03 UTC (permalink / raw)
  To: tyreld, david.daney, gregkh, robh; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()

to the 4.11-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     of-fix-cpus-reference-leak-in-of_numa_parse_cpu_nodes.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From b8475cbee5ab2eac05f9cd5dbcc94c453d3cbf10 Mon Sep 17 00:00:00 2001
From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Date: Mon, 17 Apr 2017 20:29:17 -0400
Subject: of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()

From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>

commit b8475cbee5ab2eac05f9cd5dbcc94c453d3cbf10 upstream.

The call to of_find_node_by_path("/cpus") returns the cpus device_node
with its reference count incremented. There is no matching of_node_put()
call in of_numa_parse_cpu_nodes() which results in a leaked reference
to the "/cpus" node.

This patch adds an of_node_put() to release the reference.

fixes: 298535c00a2c ("of, numa: Add NUMA of binding implementation.")
Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Acked-by: David Daney <david.daney@cavium.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/of/of_numa.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/of/of_numa.c
+++ b/drivers/of/of_numa.c
@@ -57,6 +57,8 @@ static void __init of_numa_parse_cpu_nod
 		else
 			node_set(nid, numa_nodes_parsed);
 	}
+
+	of_node_put(cpus);
 }
 
 static int __init of_numa_parse_memory_nodes(void)


Patches currently in stable-queue which might be from tyreld@linux.vnet.ibm.com are

queue-4.11/of-fix-cpus-reference-leak-in-of_numa_parse_cpu_nodes.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-05-22 17:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-22 17:03 Patch "of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()" has been added to the 4.11-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).