From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:57098 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965950AbdEWNmw (ORCPT ); Tue, 23 May 2017 09:42:52 -0400 Subject: Patch "[media] gspca: konica: add missing endpoint sanity check" has been added to the 4.9-stable tree To: johan@kernel.org, gregkh@linuxfoundation.org, hansverk@cisco.com, hdegoede@redhat.com, mchehab@s-opensource.com Cc: , From: Date: Tue, 23 May 2017 15:41:48 +0200 Message-ID: <1495546908114198@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled [media] gspca: konica: add missing endpoint sanity check to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: gspca-konica-add-missing-endpoint-sanity-check.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From aa58fedb8c7b6cf2f05941d238495f9e2f29655c Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Mon, 13 Mar 2017 09:53:59 -0300 Subject: [media] gspca: konica: add missing endpoint sanity check From: Johan Hovold commit aa58fedb8c7b6cf2f05941d238495f9e2f29655c upstream. Make sure to check the number of endpoints to avoid accessing memory beyond the endpoint array should a device lack the expected endpoints. Note that, as far as I can tell, the gspca framework has already made sure there is at least one endpoint in the current alternate setting so there should be no risk for a NULL-pointer dereference here. Fixes: b517af722860 ("V4L/DVB: gspca_konica: New gspca subdriver for konica chipset using cams") Cc: Hans de Goede Signed-off-by: Johan Hovold Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/gspca/konica.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/media/usb/gspca/konica.c +++ b/drivers/media/usb/gspca/konica.c @@ -188,6 +188,9 @@ static int sd_start(struct gspca_dev *gs return -EIO; } + if (alt->desc.bNumEndpoints < 2) + return -ENODEV; + packet_size = le16_to_cpu(alt->endpoint[0].desc.wMaxPacketSize); n = gspca_dev->cam.cam_mode[gspca_dev->curr_mode].priv; Patches currently in stable-queue which might be from johan@kernel.org are queue-4.9/cx231xx-audio-fix-null-deref-at-probe.patch queue-4.9/usb-serial-io_ti-fix-div-by-zero-in-set_termios.patch queue-4.9/usb-chaoskey-fix-alea-quirk-on-big-endian-hosts.patch queue-4.9/usb-hub-fix-non-ss-hub-descriptor-handling.patch queue-4.9/cx231xx-cards-fix-null-deref-at-probe.patch queue-4.9/usb-serial-ftdi_sio-add-olimex-arm-usb-tiny-h-pids.patch queue-4.9/usb-serial-ftdi_sio-fix-setting-latency-for-unprivileged-users.patch queue-4.9/usb-iowarrior-fix-info-ioctl-on-big-endian-hosts.patch queue-4.9/watchdog-pcwd_usb-fix-null-deref-at-probe.patch queue-4.9/gspca-konica-add-missing-endpoint-sanity-check.patch queue-4.9/usb-serial-qcserial-add-more-lenovo-em74xx-device-ids.patch queue-4.9/usb-serial-option-add-telit-me910-support.patch queue-4.9/net-irda-irda-usb-fix-firmware-name-on-big-endian-hosts.patch queue-4.9/dib0700-fix-null-deref-at-probe.patch queue-4.9/cx231xx-audio-fix-init-error-path.patch queue-4.9/of-fdt-add-missing-allocation-failure-check.patch queue-4.9/usbvision-fix-null-deref-at-probe.patch queue-4.9/usb-serial-mct_u232-fix-big-endian-baud-rate-handling.patch queue-4.9/mceusb-fix-null-deref-at-probe.patch queue-4.9/usb-hub-fix-ss-hub-descriptor-handling.patch queue-4.9/ath9k_htc-fix-null-deref-at-probe.patch queue-4.9/usb-musb-fix-trying-to-suspend-while-active-for-otg-configurations.patch