From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from imap0.codethink.co.uk ([185.43.218.159]:35570 "EHLO
        imap0.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751247AbdFBLew (ORCPT
        <rfc822;stable@vger.kernel.org>); Fri, 2 Jun 2017 07:34:52 -0400
Message-ID: <1496403267.1989.5.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 075/103] [media] dvb-frontends/cxd2841er: define
 symbol_rate_min/max in T/C fe-ops
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Daniel Scheller <d.scheller@gmx.net>,
        Abylay Ospan <aospan@netup.ru>,
        Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Fri, 02 Jun 2017 12:34:27 +0100
In-Reply-To: <20170523200902.738917213@linuxfoundation.org>
References: <20170523200856.903752266@linuxfoundation.org>
         <20170523200902.738917213@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Tue, 2017-05-23 at 22:09 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Daniel Scheller <d.scheller@gmx.net>
> 
> commit 158f0328af86a99d64073851967a02694bff987d upstream.
> 
> Fixes "w_scan -f c" complaining with
> 
>   This dvb driver is *buggy*: the symbol rate limits are undefined - please
>   report to linuxtv.org)
> 
> Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
> Acked-by: Abylay Ospan <aospan@netup.ru>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

In 4.4 this driver had two separate ops structures for DVB-T and DVB-C,
and this is only updating the DVB-C ops.  I think this needs a second
patch to cover DVB-T.

Ben.

> ---
>  drivers/media/dvb-frontends/cxd2841er.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> --- a/drivers/media/dvb-frontends/cxd2841er.c
> +++ b/drivers/media/dvb-frontends/cxd2841er.c
> @@ -2678,7 +2678,9 @@ static struct  dvb_frontend_ops cxd2841e
>  			FE_CAN_MUTE_TS |
>  			FE_CAN_2G_MODULATION,
>  		.frequency_min = 42000000,
> -		.frequency_max = 1002000000
> +		.frequency_max = 1002000000,
> +		.symbol_rate_min = 870000,
> +		.symbol_rate_max = 11700000
>  	},
>  	.init = cxd2841er_init_tc,
>  	.sleep = cxd2841er_sleep_tc,
> 
> 
> 

-- 
Ben Hutchings
Software Developer, Codethink Ltd.