From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa6.hgst.iphmx.com ([216.71.154.45]:37588 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbdFBQw4 (ORCPT ); Fri, 2 Jun 2017 12:52:56 -0400 From: Bart Van Assche To: "nab@linux-iscsi.org" CC: "hch@lst.de" , "ddiss@suse.de" , "hare@suse.com" , "target-devel@vger.kernel.org" , "agrover@redhat.com" , "stable@vger.kernel.org" Subject: Re: [PATCH 04/33] target: Fix BYTCHK=0 handling for VERIFY and WRITE AND VERIFY commands Date: Fri, 2 Jun 2017 16:52:53 +0000 Message-ID: <1496422372.1214.9.camel@sandisk.com> References: <20170523234854.21452-1-bart.vanassche@sandisk.com> <20170523234854.21452-5-bart.vanassche@sandisk.com> <1496376930.27407.234.camel@haakon3.risingtidesystems.com> In-Reply-To: <1496376930.27407.234.camel@haakon3.risingtidesystems.com> Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: <0F57DC2DF840134F81A0B72A60171BDE@namprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Thu, 2017-06-01 at 21:15 -0700, Nicholas A. Bellinger wrote: > On Tue, 2017-05-23 at 16:48 -0700, Bart Van Assche wrote: > > For VERIFY and WRITE AND VERIFY commands the size of the SCSI > > Data-Out buffer can differ from the size of the data area on the > > storage medium that is affected by the command. Make sure that > > the Data-Out buffer size is computed correctly if the BYTCHK > > field in the CDB is zero. This patch reverts commit 984a9d4c40be > > and thereby restores commit 0e2eb7d12eaa. Additionally, > > sbc_parse_cdb() is modified such that the data buffer size is > > computed correctly for the affected commands if BYTCHK =3D=3D 0. > > This patch is the combination of two patches that got positive > > reviews. > >=20 > > References: commit 984a9d4c40be ("Revert "target: Fix VERIFY and WRITE = VERIFY command parsing"") > > References: commit 0e2eb7d12eaa ("target: Fix VERIFY and WRITE VERIFY c= ommand parsing") > > Signed-off-by: Bart Van Assche > > Cc: Hannes Reinecke > > Cc: Christoph Hellwig > > Cc: Andy Grover > > Cc: David Disseldorp > > Cc: > > --- > > drivers/target/target_core_sbc.c | 79 ++++++++++++++++++++++++++++++++= ++------ > > 1 file changed, 67 insertions(+), 12 deletions(-) > >=20 >=20 > This patch ignored the review comments from the last round: >=20 > http://www.spinics.net/lists/target-devel/msg15306.html > http://www.spinics.net/lists/target-devel/msg15327.html >=20 > Until these are addressed as requested, dropping this patch for now. Hello Nic, In this patch series I have addressed all comments that made sense to me. S= orry if you feel offended because I had not addressed the two comments you refer= red to above. The reason I had not addressed these comments is because these comme= nts are wrong in my opinion. Hence, please reconsider this patch. Bart.=