Patch "ipv6: Fix leak in ipv6_gso_segment()." has been added to the 4.4-stable tree

Patch "ipv6: Fix leak in ipv6_gso_segment()." has been added to the 4.4-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    ipv6: Fix leak in ipv6_gso_segment().

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ipv6-fix-leak-in-ipv6_gso_segment.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Thu Jun  8 09:11:25 CEST 2017
From: "David S. Miller" <davem@davemloft.net>
Date: Sun, 4 Jun 2017 21:41:10 -0400
Subject: ipv6: Fix leak in ipv6_gso_segment().

From: "David S. Miller" <davem@davemloft.net>


[ Upstream commit e3e86b5119f81e5e2499bea7ea1ebe8ac6aab789 ]

If ip6_find_1stfragopt() fails and we return an error we have to free
up 'segs' because nobody else is going to.

Fixes: 2423496af35d ("ipv6: Prevent overrun when parsing v6 header options")
Reported-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 net/ipv6/ip6_offload.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/net/ipv6/ip6_offload.c
+++ b/net/ipv6/ip6_offload.c
@@ -121,8 +121,10 @@ static struct sk_buff *ipv6_gso_segment(
 
 		if (udpfrag) {
 			int err = ip6_find_1stfragopt(skb, &prevhdr);
-			if (err < 0)
+			if (err < 0) {
+				kfree_skb_list(segs);
 				return ERR_PTR(err);
+			}
 			fptr = (struct frag_hdr *)((u8 *)ipv6h + err);
 			fptr->frag_off = htons(offset);
 			if (skb->next)


Patches currently in stable-queue which might be from davem@davemloft.net are

queue-4.4/sparc64-new-context-wrap.patch
queue-4.4/sparc64-add-__multi3-for-gcc-7.x-and-later.patch
queue-4.4/sparc-machine-description-indices-can-vary.patch
queue-4.4/sparc64-combine-activate_mm-and-switch_mm.patch
queue-4.4/sparc64-add-per-cpu-mm-of-secondary-contexts.patch
queue-4.4/net-bridge-start-hello-timer-only-if-device-is-up.patch
queue-4.4/sparc64-mm-fix-copy_tsb-to-correctly-copy-huge-page-tsbs.patch
queue-4.4/sparc64-reset-mm-cpumask-after-wrap.patch
queue-4.4/vxlan-fix-use-after-free-on-deletion.patch
queue-4.4/net-ethoc-enable-napi-before-poll-may-be-scheduled.patch
queue-4.4/cxgb4-avoid-enabling-napi-twice-to-the-same-queue.patch
queue-4.4/tcp-disallow-cwnd-undo-when-switching-congestion-control.patch
queue-4.4/sparc64-redefine-first-version.patch
queue-4.4/ipv6-xfrm-handle-errors-reported-by-xfrm6_find_1stfragopt.patch
queue-4.4/sparc64-delete-old-wrap-code.patch
queue-4.4/bnx2x-fix-multi-cos.patch
queue-4.4/net-ping-do-not-abuse-udp_poll.patch
queue-4.4/ipv6-fix-leak-in-ipv6_gso_segment.patch
queue-4.4/arch-sparc-support-nr_cpus-4096.patch