From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:40334 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506AbdF2Ror (ORCPT ); Thu, 29 Jun 2017 13:44:47 -0400 Subject: Patch "net: Zero ifla_vf_info in rtnl_fill_vfinfo()" has been added to the 4.4-stable tree To: Yuval.Mintz@cavium.com, davem@davemloft.net, gregkh@linuxfoundation.org, gvrose8192@gmail.com, mschmidt@redhat.com Cc: , From: Date: Thu, 29 Jun 2017 19:44:31 +0200 Message-ID: <14987582711678@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled net: Zero ifla_vf_info in rtnl_fill_vfinfo() to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: net-zero-ifla_vf_info-in-rtnl_fill_vfinfo.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From foo@baz Thu Jun 29 19:38:17 CEST 2017 From: "Mintz, Yuval" Date: Wed, 7 Jun 2017 21:00:33 +0300 Subject: net: Zero ifla_vf_info in rtnl_fill_vfinfo() From: "Mintz, Yuval" [ Upstream commit 0eed9cf58446b28b233388b7f224cbca268b6986 ] Some of the structure's fields are not initialized by the rtnetlink. If driver doesn't set those in ndo_get_vf_config(), they'd leak memory to user. Signed-off-by: Yuval Mintz CC: Michal Schmidt Reviewed-by: Greg Rose Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/core/rtnetlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -1089,6 +1089,8 @@ static noinline_for_stack int rtnl_fill_ struct ifla_vf_mac vf_mac; struct ifla_vf_info ivi; + memset(&ivi, 0, sizeof(ivi)); + /* Not all SR-IOV capable drivers support the * spoofcheck and "RSS query enable" query. Preset to * -1 so the user space tool can detect that the driver @@ -1097,7 +1099,6 @@ static noinline_for_stack int rtnl_fill_ ivi.spoofchk = -1; ivi.rss_query_en = -1; ivi.trusted = -1; - memset(ivi.mac, 0, sizeof(ivi.mac)); /* The default value for VF link state is "auto" * IFLA_VF_LINK_STATE_AUTO which equals zero */ Patches currently in stable-queue which might be from Yuval.Mintz@cavium.com are queue-4.4/net-zero-ifla_vf_info-in-rtnl_fill_vfinfo.patch