* Patch "net: phy: fix sign type error in genphy_config_eee_advert" has been added to the 4.9-stable tree
@ 2017-07-03 9:02 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-07-03 9:02 UTC (permalink / raw)
To: jbrunet, alexander.levin, davem, gregkh, julia.lawall
Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
net: phy: fix sign type error in genphy_config_eee_advert
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-phy-fix-sign-type-error-in-genphy_config_eee_advert.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From foo@baz Mon Jul 3 11:00:33 CEST 2017
From: jbrunet <jbrunet@baylibre.com>
Date: Mon, 19 Dec 2016 16:05:36 +0100
Subject: net: phy: fix sign type error in genphy_config_eee_advert
From: jbrunet <jbrunet@baylibre.com>
[ Upstream commit 3bb9ab63276696988d8224f52db20e87194deb4b ]
In genphy_config_eee_advert, the return value of phy_read_mmd_indirect is
checked to know if the register could be accessed but the result is
assigned to a 'u32'.
Changing to 'int' to correctly get errors from phy_read_mmd_indirect.
Fixes: d853d145ea3e ("net: phy: add an option to disable EEE advertisement")
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/net/phy/phy_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1155,8 +1155,8 @@ static int genphy_config_advert(struct p
*/
static int genphy_config_eee_advert(struct phy_device *phydev)
{
- u32 broken = phydev->eee_broken_modes;
- u32 old_adv, adv;
+ int broken = phydev->eee_broken_modes;
+ int old_adv, adv;
/* Nothing to disable */
if (!broken)
Patches currently in stable-queue which might be from jbrunet@baylibre.com are
queue-4.9/net-phy-add-an-option-to-disable-eee-advertisement.patch
queue-4.9/dt-bindings-net-add-eee-capability-constants.patch
queue-4.9/net-phy-use-boolean-dt-properties-for-eee-broken-modes.patch
queue-4.9/arm64-dts-meson-gxbb-odroidc2-fix-gbe-tx-link-breakage.patch
queue-4.9/net-phy-fix-sign-type-error-in-genphy_config_eee_advert.patch
queue-4.9/dt-bindings-net-use-boolean-dt-properties-for-eee-broken-modes.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-07-03 9:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-03 9:02 Patch "net: phy: fix sign type error in genphy_config_eee_advert" has been added to the 4.9-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).