stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "ext4: check return value of kstrtoull correctly in reserved_clusters_store" has been added to the 4.4-stable tree
@ 2017-07-13 14:47 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-07-13 14:47 UTC (permalink / raw)
  To: yuchao0, gregkh, miaoxie, tytso; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    ext4: check return value of kstrtoull correctly in reserved_clusters_store

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ext4-check-return-value-of-kstrtoull-correctly-in-reserved_clusters_store.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 1ea1516fbbab2b30bf98c534ecaacba579a35208 Mon Sep 17 00:00:00 2001
From: Chao Yu <yuchao0@huawei.com>
Date: Fri, 23 Jun 2017 01:08:22 -0400
Subject: ext4: check return value of kstrtoull correctly in reserved_clusters_store

From: Chao Yu <yuchao0@huawei.com>

commit 1ea1516fbbab2b30bf98c534ecaacba579a35208 upstream.

kstrtoull returns 0 on success, however, in reserved_clusters_store we
will return -EINVAL if kstrtoull returns 0, it makes us fail to update
reserved_clusters value through sysfs.

Fixes: 76d33bca5581b1dd5c3157fa168db849a784ada4
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Miao Xie <miaoxie@huawei.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/ext4/sysfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/ext4/sysfs.c
+++ b/fs/ext4/sysfs.c
@@ -100,7 +100,7 @@ static ssize_t reserved_clusters_store(s
 	int ret;
 
 	ret = kstrtoull(skip_spaces(buf), 0, &val);
-	if (!ret || val >= clusters)
+	if (ret || val >= clusters)
 		return -EINVAL;
 
 	atomic64_set(&sbi->s_resv_clusters, val);


Patches currently in stable-queue which might be from yuchao0@huawei.com are

queue-4.4/ext4-check-return-value-of-kstrtoull-correctly-in-reserved_clusters_store.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-07-13 14:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-13 14:47 Patch "ext4: check return value of kstrtoull correctly in reserved_clusters_store" has been added to the 4.4-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).