stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "rds: tcp: use sock_create_lite() to create the accept socket" has been added to the 4.9-stable tree
@ 2017-07-18  9:52 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-07-18  9:52 UTC (permalink / raw)
  To: sowmini.varadhan, davem, gregkh, santosh.shilimkar; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    rds: tcp: use sock_create_lite() to create the accept socket

to the 4.9-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     rds-tcp-use-sock_create_lite-to-create-the-accept-socket.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 0933a578cd55b02dc80f219dc8f2efb17ec61c9a Mon Sep 17 00:00:00 2001
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Thu, 6 Jul 2017 08:15:06 -0700
Subject: rds: tcp: use sock_create_lite() to create the accept socket

From: Sowmini Varadhan <sowmini.varadhan@oracle.com>

commit 0933a578cd55b02dc80f219dc8f2efb17ec61c9a upstream.

There are two problems with calling sock_create_kern() from
rds_tcp_accept_one()
1. it sets up a new_sock->sk that is wasteful, because this ->sk
   is going to get replaced by inet_accept() in the subsequent ->accept()
2. The new_sock->sk is a leaked reference in sock_graft() which
   expects to find a null parent->sk

Avoid these problems by calling sock_create_lite().

Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 net/rds/tcp_listen.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/rds/tcp_listen.c
+++ b/net/rds/tcp_listen.c
@@ -129,7 +129,7 @@ int rds_tcp_accept_one(struct socket *so
 	if (!sock) /* module unload or netns delete in progress */
 		return -ENETUNREACH;
 
-	ret = sock_create_kern(sock_net(sock->sk), sock->sk->sk_family,
+	ret = sock_create_lite(sock->sk->sk_family,
 			       sock->sk->sk_type, sock->sk->sk_protocol,
 			       &new_sock);
 	if (ret)


Patches currently in stable-queue which might be from sowmini.varadhan@oracle.com are

queue-4.9/rds-tcp-use-sock_create_lite-to-create-the-accept-socket.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-07-18  9:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-18  9:52 Patch "rds: tcp: use sock_create_lite() to create the accept socket" has been added to the 4.9-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).