From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:54056 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752881AbdGSIb7 (ORCPT ); Wed, 19 Jul 2017 04:31:59 -0400 Subject: Patch "pstore: Fix leaked pstore_record in pstore_get_backend_records()" has been added to the 4.12-stable tree To: dianders@chromium.org, gregkh@linuxfoundation.org, keescook@chromium.org Cc: , From: Date: Wed, 19 Jul 2017 10:31:44 +0200 Message-ID: <15004531041979@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled pstore: Fix leaked pstore_record in pstore_get_backend_records() to the 4.12-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: pstore-fix-leaked-pstore_record-in-pstore_get_backend_records.patch and it can be found in the queue-4.12 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From f6525b96dd9f68efe374e5aef864975e628de991 Mon Sep 17 00:00:00 2001 From: Douglas Anderson Date: Tue, 30 May 2017 15:50:38 -0700 Subject: pstore: Fix leaked pstore_record in pstore_get_backend_records() From: Douglas Anderson commit f6525b96dd9f68efe374e5aef864975e628de991 upstream. When the "if (record->size <= 0)" test is true in pstore_get_backend_records() it's pretty clear that nobody holds a reference to the allocated pstore_record, yet we don't free it. Let's free it. Fixes: 2a2b0acf768c ("pstore: Allocate records on heap instead of stack") Signed-off-by: Douglas Anderson Signed-off-by: Kees Cook Signed-off-by: Greg Kroah-Hartman --- fs/pstore/platform.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c @@ -846,8 +846,10 @@ void pstore_get_backend_records(struct p record->size = psi->read(record); /* No more records left in backend? */ - if (record->size <= 0) + if (record->size <= 0) { + kfree(record); break; + } decompress_record(record); rc = pstore_mkfile(root, record); Patches currently in stable-queue which might be from dianders@chromium.org are queue-4.12/pstore-fix-leaked-pstore_record-in-pstore_get_backend_records.patch