From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:35600 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753466AbdGSJn2 (ORCPT ); Wed, 19 Jul 2017 05:43:28 -0400 Subject: Patch "PM / QoS: return -EINVAL for bogus strings" has been added to the 3.18-stable tree To: dan.carpenter@oracle.com, gregkh@linuxfoundation.org, pavel@ucw.cz, rafael.j.wysocki@intel.com Cc: , From: Date: Wed, 19 Jul 2017 11:43:17 +0200 Message-ID: <1500457397134219@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled PM / QoS: return -EINVAL for bogus strings to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: pm-qos-return-einval-for-bogus-strings.patch and it can be found in the queue-3.18 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 2ca30331c156ca9e97643ad05dd8930b8fe78b01 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Mon, 10 Jul 2017 10:21:40 +0300 Subject: PM / QoS: return -EINVAL for bogus strings From: Dan Carpenter commit 2ca30331c156ca9e97643ad05dd8930b8fe78b01 upstream. In the current code, if the user accidentally writes a bogus command to this sysfs file, then we set the latency tolerance to an uninitialized variable. Fixes: 2d984ad132a8 (PM / QoS: Introcuce latency tolerance device PM QoS type) Signed-off-by: Dan Carpenter Acked-by: Pavel Machek Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/base/power/sysfs.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/base/power/sysfs.c +++ b/drivers/base/power/sysfs.c @@ -269,6 +269,8 @@ static ssize_t pm_qos_latency_tolerance_ value = PM_QOS_LATENCY_TOLERANCE_NO_CONSTRAINT; else if (!strcmp(buf, "any") || !strcmp(buf, "any\n")) value = PM_QOS_LATENCY_ANY; + else + return -EINVAL; } ret = dev_pm_qos_update_user_latency_tolerance(dev, value); return ret < 0 ? ret : n; Patches currently in stable-queue which might be from dan.carpenter@oracle.com are queue-3.18/pm-qos-return-einval-for-bogus-strings.patch