From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:32804 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752074AbdHCWoc (ORCPT ); Thu, 3 Aug 2017 18:44:32 -0400 Subject: Patch "mailbox: always wait in mbox_send_message for blocking Tx mode" has been added to the 4.9-stable tree To: sudeep.holla@arm.com, alexey.klimov@arm.com, amit.pundir@linaro.org, gregkh@linuxfoundation.org, jaswinder.singh@linaro.org Cc: , From: Date: Thu, 03 Aug 2017 15:44:28 -0700 Message-ID: <15018002685523@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled mailbox: always wait in mbox_send_message for blocking Tx mode to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: mailbox-always-wait-in-mbox_send_message-for-blocking-tx-mode.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From c61b781ee084e69855477d23dd33e7e6caad652c Mon Sep 17 00:00:00 2001 From: Sudeep Holla Date: Tue, 21 Mar 2017 11:30:14 +0000 Subject: mailbox: always wait in mbox_send_message for blocking Tx mode From: Sudeep Holla commit c61b781ee084e69855477d23dd33e7e6caad652c upstream. There exists a race when msg_submit return immediately as there was an active request being processed which may have completed just before it's checked again in mbox_send_message. This will result in return to the caller without waiting in mbox_send_message even when it's blocking Tx. This patch fixes the issue by waiting for the completion always if Tx is in blocking mode. Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox") Reported-by: Alexey Klimov Signed-off-by: Sudeep Holla Reviewed-by: Alexey Klimov Signed-off-by: Jassi Brar Signed-off-by: Amit Pundir Signed-off-by: Greg Kroah-Hartman --- drivers/mailbox/mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -261,7 +261,7 @@ int mbox_send_message(struct mbox_chan * msg_submit(chan); - if (chan->cl->tx_block && chan->active_req) { + if (chan->cl->tx_block) { unsigned long wait; int ret; Patches currently in stable-queue which might be from sudeep.holla@arm.com are queue-4.9/mailbox-always-wait-in-mbox_send_message-for-blocking-tx-mode.patch queue-4.9/mailbox-skip-complete-wait-event-if-timer-expired.patch queue-4.9/mailbox-handle-empty-message-in-tx_tick.patch