* Patch "drm/msm: Verify that MSM_SUBMIT_BO_FLAGS are set" has been added to the 4.4-stable tree
@ 2017-08-04 21:45 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-08-04 21:45 UTC (permalink / raw)
To: jcrouse, alexander.levin, gregkh, robdclark; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
drm/msm: Verify that MSM_SUBMIT_BO_FLAGS are set
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-msm-verify-that-msm_submit_bo_flags-are-set.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From foo@baz Fri Aug 4 13:34:53 PDT 2017
From: Jordan Crouse <jcrouse@codeaurora.org>
Date: Tue, 20 Dec 2016 08:54:31 -0700
Subject: drm/msm: Verify that MSM_SUBMIT_BO_FLAGS are set
From: Jordan Crouse <jcrouse@codeaurora.org>
[ Upstream commit a6cb3b864b21b7345f824a4faa12b723c8aaf099 ]
For every submission buffer object one of MSM_SUBMIT_BO_WRITE
and MSM_SUBMIT_BO_READ must be set (and nothing else). If we
allowed zero then the buffer object would never get queued to
be unreferenced.
Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/gpu/drm/msm/msm_gem_submit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/gpu/drm/msm/msm_gem_submit.c
+++ b/drivers/gpu/drm/msm/msm_gem_submit.c
@@ -90,7 +90,8 @@ static int submit_lookup_objects(struct
pagefault_disable();
}
- if (submit_bo.flags & ~MSM_SUBMIT_BO_FLAGS) {
+ if ((submit_bo.flags & ~MSM_SUBMIT_BO_FLAGS) ||
+ !(submit_bo.flags & MSM_SUBMIT_BO_FLAGS)) {
DRM_ERROR("invalid flags: %x\n", submit_bo.flags);
ret = -EINVAL;
goto out_unlock;
Patches currently in stable-queue which might be from jcrouse@codeaurora.org are
queue-4.4/drm-msm-verify-that-msm_submit_bo_flags-are-set.patch
queue-4.4/drm-msm-ensure-that-the-hardware-write-pointer-is-valid.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-08-04 21:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-04 21:45 Patch "drm/msm: Verify that MSM_SUBMIT_BO_FLAGS are set" has been added to the 4.4-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).