From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "hch@lst.de" <hch@lst.de>
Cc: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hare@suse.de" <hare@suse.de>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] scsi_transport_sas: Fix error handling in sas_smp_request()
Date: Fri, 25 Aug 2017 15:38:48 +0000 [thread overview]
Message-ID: <1503675527.2680.1.camel@wdc.com> (raw)
In-Reply-To: <20170825153529.GB18440@lst.de>
On Fri, 2017-08-25 at 17:35 +0200, Christoph Hellwig wrote:
> I looked a bit more at the history of this, and it seems like the only
> issue with commit 17d5363b83f8 here is using the blk_status_t type for the
> ret variable. Even before that the negative error code leaked out
> to userspace. We can try to just turn that back into an int, but I'll
> also send out an RFC patch to use bsg-lib for the SAS transport in a bit.
Hello Christoph,
Do you want me to split this patch in two patches - one that changes the type
of 'ret' and another one that translates the Unix error code into a SCSI result?
Thanks,
Bart.
next prev parent reply other threads:[~2017-08-25 15:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 18:25 [PATCH] scsi_transport_sas: Fix error handling in sas_smp_request() Bart Van Assche
2017-08-24 8:47 ` Christoph Hellwig
2017-08-24 12:21 ` Hannes Reinecke
2017-08-24 16:06 ` Bart Van Assche
2017-08-25 8:54 ` Hannes Reinecke
2017-08-25 15:35 ` Christoph Hellwig
2017-08-25 15:38 ` Bart Van Assche [this message]
2017-08-25 15:57 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503675527.2680.1.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox