Re: [PATCH 3.16 119/134] ipv4: restore rt->fi for reference counting

Ben Hutchings
2017-08-26T00:33:22Z

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

On Fri, 2017-08-18 at 06:53 -0700, Eric Dumazet wrote:
> > On Fri, Aug 18, 2017 at 6:13 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
> > 3.16.47-rc1 review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: WANG Cong <xiyou.wangcong@gmail.com>
> >
> > commit 82486aa6f1b9bc8145e6d0fa2bc0b44307f3b875 upstream.
[...]
> I thought we refined this later with :

In fact it was reverted upstream, then replaced by the commits you
point out. Thanks; I don't know why I missed that.

> commit 3fb07daff8e99243366a081e5129560734de4ada
> Author: Eric Dumazet <edumazet@google.com>
> Date:   Thu May 25 14:27:35 2017 -0700
>
>     ipv4: add reference counting to metrics
[...]

It's not obvious how to backport this, as it adds:

+#define DST_METRICS_REFCOUNTED 0x2UL

but 3.16 already has a flag with value 2. I don't think we can take
another bit from the pointer as metrics are only 32-bit aligned.

Ben.

--
Ben Hutchings
One of the nice things about standards is that there are so many of
them.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]