From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:45074 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbdH0MhU (ORCPT ); Sun, 27 Aug 2017 08:37:20 -0400 Subject: Patch "drm: rcar-du: Fix crash in encoder failure error path" has been added to the 4.4-stable tree To: laurent.pinchart+renesas@ideasonboard.com, gregkh@linuxfoundation.org, gustavo.padovan@collabora.co.uk, nhan.nguyen.yb@renesas.com, thong.ho.px@rvc.renesas.com Cc: , From: Date: Sun, 27 Aug 2017 14:37:19 +0200 Message-ID: <150383743923383@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled drm: rcar-du: Fix crash in encoder failure error path to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-rcar-du-fix-crash-in-encoder-failure-error-path.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 05ee29e94acf0d4b3998c3f93374952de8f90176 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Mon, 3 Oct 2016 20:03:22 +0300 Subject: drm: rcar-du: Fix crash in encoder failure error path From: Laurent Pinchart commit 05ee29e94acf0d4b3998c3f93374952de8f90176 upstream. When an encoder fails to initialize the driver prints an error message to the kernel log. The message contains the name of the encoder's DT node, which is NULL for internal encoders. Use the of_node_full_name() macro to avoid dereferencing a NULL pointer, print the output number to add more context to the error, and make sure we still own a reference to the encoder's DT node by delaying the of_node_put() call. Signed-off-by: Laurent Pinchart Reviewed-by: Gustavo Padovan Signed-off-by: Thong Ho Signed-off-by: Nhan Nguyen Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c @@ -642,13 +642,13 @@ static int rcar_du_encoders_init_one(str } ret = rcar_du_encoder_init(rcdu, enc_type, output, encoder, connector); - of_node_put(encoder); - of_node_put(connector); - if (ret && ret != -EPROBE_DEFER) dev_warn(rcdu->dev, - "failed to initialize encoder %s (%d), skipping\n", - encoder->full_name, ret); + "failed to initialize encoder %s on output %u (%d), skipping\n", + of_node_full_name(encoder), output, ret); + + of_node_put(encoder); + of_node_put(connector); return ret; } Patches currently in stable-queue which might be from laurent.pinchart+renesas@ideasonboard.com are queue-4.4/drm-rcar-du-lvds-rename-pllen-bit-to-pllon.patch queue-4.4/drm-rcar-du-fix-crash-in-encoder-failure-error-path.patch queue-4.4/drm-rcar-du-fix-h-v-sync-signal-polarity-configuration.patch queue-4.4/drm-rcar-du-fix-display-timing-controller-parameter.patch queue-4.4/drm-rcar-du-lvds-fix-pll-frequency-related-configuration.patch