stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "mm/sparse.c: fix typo in online_mem_sections" has been added to the 4.13-stable tree
@ 2017-09-10 11:37 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-09-10 11:37 UTC (permalink / raw)
  To: mhocko, akpm, gregkh, khandual, torvalds, vbabka; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    mm/sparse.c: fix typo in online_mem_sections

to the 4.13-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     mm-sparse.c-fix-typo-in-online_mem_sections.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From b4ccec41af82b5a5518c6534444412961894f07c Mon Sep 17 00:00:00 2001
From: Michal Hocko <mhocko@suse.com>
Date: Fri, 8 Sep 2017 16:13:15 -0700
Subject: mm/sparse.c: fix typo in online_mem_sections

From: Michal Hocko <mhocko@suse.com>

commit b4ccec41af82b5a5518c6534444412961894f07c upstream.

online_mem_sections() accidentally marks online only the first section
in the given range.  This is a typo which hasn't been noticed because I
haven't tested large 2GB blocks previously.  All users of
pfn_to_online_page would get confused on the the rest of the pfn range
in the block.

All we need to fix this is to use iterator (pfn) rather than start_pfn.

Link: http://lkml.kernel.org/r/20170904112210.3401-1-mhocko@kernel.org
Fixes: 2d070eab2e82 ("mm: consider zone which is not fully populated to have holes")
Signed-off-by: Michal Hocko <mhocko@suse.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 mm/sparse.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -630,7 +630,7 @@ void online_mem_sections(unsigned long s
 	unsigned long pfn;
 
 	for (pfn = start_pfn; pfn < end_pfn; pfn += PAGES_PER_SECTION) {
-		unsigned long section_nr = pfn_to_section_nr(start_pfn);
+		unsigned long section_nr = pfn_to_section_nr(pfn);
 		struct mem_section *ms;
 
 		/* onlining code should never touch invalid ranges */


Patches currently in stable-queue which might be from mhocko@suse.com are

queue-4.13/mm-memory.c-fix-mem_cgroup_oom_disable-call-missing.patch
queue-4.13/mm-sparse.c-fix-typo-in-online_mem_sections.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-09-10 12:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-10 11:37 Patch "mm/sparse.c: fix typo in online_mem_sections" has been added to the 4.13-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).