Patch "net: systemport: Free DMA coherent descriptors on errors" has been added to the 4.12-stable tree

Patch "net: systemport: Free DMA coherent descriptors on errors" has been added to the 4.12-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    net: systemport: Free DMA coherent descriptors on errors

to the 4.12-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     net-systemport-free-dma-coherent-descriptors-on-errors.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Thu Sep 14 23:20:23 PDT 2017
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 24 Aug 2017 16:01:13 -0700
Subject: net: systemport: Free DMA coherent descriptors on errors

From: Florian Fainelli <f.fainelli@gmail.com>


[ Upstream commit c2062ee3d9615828109ffe8089fbf69bed394d05 ]

In case bcm_sysport_init_tx_ring() is not able to allocate ring->cbs, we
would return with an error, and call bcm_sysport_fini_tx_ring() and it
would see that ring->cbs is NULL and do nothing. This would leak the
coherent DMA descriptor area, so we need to free it on error before
returning.

Reported-by: Eric Dumazet <edumazet@gmail.com>
Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/net/ethernet/broadcom/bcmsysport.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -1342,6 +1342,8 @@ static int bcm_sysport_init_tx_ring(stru
 
 	ring->cbs = kcalloc(size, sizeof(struct bcm_sysport_cb), GFP_KERNEL);
 	if (!ring->cbs) {
+		dma_free_coherent(kdev, sizeof(struct dma_desc),
+				  ring->desc_cpu, ring->desc_dma);
 		netif_err(priv, hw, priv->netdev, "CB allocation failed\n");
 		return -ENOMEM;
 	}


Patches currently in stable-queue which might be from f.fainelli@gmail.com are

queue-4.12/net-systemport-be-drop-monitor-friendly.patch
queue-4.12/net-bcmgenet-be-drop-monitor-friendly.patch
queue-4.12/net-dsa-bcm_sf2-fix-number-of-cfp-entries-for-bcm7278.patch
queue-4.12/net-systemport-free-dma-coherent-descriptors-on-errors.patch
queue-4.12/fsl-man-inherit-parent-device-and-of_node.patch
queue-4.12/revert-net-phy-correctly-process-phy_halted-in-phy_stop_machine.patch