* Patch "[PATCH] Revert "usb: musb: fix tx fifo flush handling again"" has been added to the 3.18-stable tree
@ 2017-09-20 10:34 gregkh
2017-09-20 13:20 ` Bin Liu
0 siblings, 1 reply; 4+ messages in thread
From: gregkh @ 2017-09-20 10:34 UTC (permalink / raw)
To: gregkh, b-liu, gkaiser; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
[PATCH] Revert "usb: musb: fix tx fifo flush handling again"
to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
revert-usb-musb-fix-tx-fifo-flush-handling-again.patch
and it can be found in the queue-3.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 817bdbb406234e405e01790dfc6fffd91a15367e Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Wed, 20 Sep 2017 12:31:05 +0200
Subject: [PATCH] Revert "usb: musb: fix tx fifo flush handling again"
This reverts commit 98b91bfa5e478b9bf332f9f149b1c25ffd58f877 which is
commit 45d73860530a14c608f410b91c6c341777bfa85d upstream.
It should not have been applied to the 3.18-stable tree at all.
Reported-by: Greg Kaiser <gkaiser@google.com>
Cc: Bin Liu <b-liu@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/musb/musb_host.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -1294,7 +1294,6 @@ void musb_host_tx(struct musb *musb, u8
| MUSB_TXCSR_TXPKTRDY);
}
return;
- mdelay(1);
}
done:
Patches currently in stable-queue which might be from gregkh@linuxfoundation.org are
queue-3.18/qlge-avoid-memcpy-buffer-overflow.patch
queue-3.18/revert-net-phy-correctly-process-phy_halted-in-phy_stop_machine.patch
queue-3.18/f2fs-check-hot_data-for-roll-forward-recovery.patch
queue-3.18/ipv6-fix-memory-leak-with-multiple-tables-during-netns-destruction.patch
queue-3.18/tcp-initialize-rcv_mss-to-tcp_min_mss-instead-of-0.patch
queue-3.18/ipv6-fix-typo-in-fib6_net_exit.patch
queue-3.18/ipv6-accept-64k-1-packet-length-in-ip6_find_1stfragopt.patch
queue-3.18/revert-usb-musb-fix-tx-fifo-flush-handling-again.patch
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Patch "[PATCH] Revert "usb: musb: fix tx fifo flush handling again"" has been added to the 3.18-stable tree
2017-09-20 10:34 Patch "[PATCH] Revert "usb: musb: fix tx fifo flush handling again"" has been added to the 3.18-stable tree gregkh
@ 2017-09-20 13:20 ` Bin Liu
2017-09-20 14:58 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Bin Liu @ 2017-09-20 13:20 UTC (permalink / raw)
To: gregkh; +Cc: gkaiser, stable, stable-commits
Hi Greg,
On Wed, Sep 20, 2017 at 12:34:14PM +0200, gregkh@linuxfoundation.org wrote:
>
> This is a note to let you know that I've just added the patch titled
>
> [PATCH] Revert "usb: musb: fix tx fifo flush handling again"
>
> to the 3.18-stable tree which can be found at:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
> revert-usb-musb-fix-tx-fifo-flush-handling-again.patch
> and it can be found in the queue-3.18 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
>
>
> From 817bdbb406234e405e01790dfc6fffd91a15367e Mon Sep 17 00:00:00 2001
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Date: Wed, 20 Sep 2017 12:31:05 +0200
> Subject: [PATCH] Revert "usb: musb: fix tx fifo flush handling again"
>
> This reverts commit 98b91bfa5e478b9bf332f9f149b1c25ffd58f877 which is
> commit 45d73860530a14c608f410b91c6c341777bfa85d upstream.
>
> It should not have been applied to the 3.18-stable tree at all.
The original commit 45d73860530a14c608f410b91c6c341777bfa85d upstream
does mention it is applicable to v4.4+,
Cc: stable@vger.kernel.org # v4.4+
but it doesn't have 'Fixes ...' line.
What is the best format of a commit message to help to prevent this
incident happen again?
Regards,
-Bin.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Patch "[PATCH] Revert "usb: musb: fix tx fifo flush handling again"" has been added to the 3.18-stable tree
2017-09-20 13:20 ` Bin Liu
@ 2017-09-20 14:58 ` Greg KH
2017-09-20 19:19 ` Bin Liu
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2017-09-20 14:58 UTC (permalink / raw)
To: Bin Liu, gkaiser, stable, stable-commits
On Wed, Sep 20, 2017 at 08:20:13AM -0500, Bin Liu wrote:
> Hi Greg,
>
> On Wed, Sep 20, 2017 at 12:34:14PM +0200, gregkh@linuxfoundation.org wrote:
> >
> > This is a note to let you know that I've just added the patch titled
> >
> > [PATCH] Revert "usb: musb: fix tx fifo flush handling again"
> >
> > to the 3.18-stable tree which can be found at:
> > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> > The filename of the patch is:
> > revert-usb-musb-fix-tx-fifo-flush-handling-again.patch
> > and it can be found in the queue-3.18 subdirectory.
> >
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> >
> >
> > From 817bdbb406234e405e01790dfc6fffd91a15367e Mon Sep 17 00:00:00 2001
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Date: Wed, 20 Sep 2017 12:31:05 +0200
> > Subject: [PATCH] Revert "usb: musb: fix tx fifo flush handling again"
> >
> > This reverts commit 98b91bfa5e478b9bf332f9f149b1c25ffd58f877 which is
> > commit 45d73860530a14c608f410b91c6c341777bfa85d upstream.
> >
> > It should not have been applied to the 3.18-stable tree at all.
>
> The original commit 45d73860530a14c608f410b91c6c341777bfa85d upstream
> does mention it is applicable to v4.4+,
>
> Cc: stable@vger.kernel.org # v4.4+
>
> but it doesn't have 'Fixes ...' line.
>
> What is the best format of a commit message to help to prevent this
> incident happen again?
You did it right, I missed it when I was applying patches, sorry, my
fault.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Patch "[PATCH] Revert "usb: musb: fix tx fifo flush handling again"" has been added to the 3.18-stable tree
2017-09-20 14:58 ` Greg KH
@ 2017-09-20 19:19 ` Bin Liu
0 siblings, 0 replies; 4+ messages in thread
From: Bin Liu @ 2017-09-20 19:19 UTC (permalink / raw)
To: Greg KH; +Cc: gkaiser, stable, stable-commits
On Wed, Sep 20, 2017 at 04:58:53PM +0200, Greg KH wrote:
> On Wed, Sep 20, 2017 at 08:20:13AM -0500, Bin Liu wrote:
> > Hi Greg,
> >
> > On Wed, Sep 20, 2017 at 12:34:14PM +0200, gregkh@linuxfoundation.org wrote:
> > >
> > > This is a note to let you know that I've just added the patch titled
> > >
> > > [PATCH] Revert "usb: musb: fix tx fifo flush handling again"
> > >
> > > to the 3.18-stable tree which can be found at:
> > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > >
> > > The filename of the patch is:
> > > revert-usb-musb-fix-tx-fifo-flush-handling-again.patch
> > > and it can be found in the queue-3.18 subdirectory.
> > >
> > > If you, or anyone else, feels it should not be added to the stable tree,
> > > please let <stable@vger.kernel.org> know about it.
> > >
> > >
> > > From 817bdbb406234e405e01790dfc6fffd91a15367e Mon Sep 17 00:00:00 2001
> > > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Date: Wed, 20 Sep 2017 12:31:05 +0200
> > > Subject: [PATCH] Revert "usb: musb: fix tx fifo flush handling again"
> > >
> > > This reverts commit 98b91bfa5e478b9bf332f9f149b1c25ffd58f877 which is
> > > commit 45d73860530a14c608f410b91c6c341777bfa85d upstream.
> > >
> > > It should not have been applied to the 3.18-stable tree at all.
> >
> > The original commit 45d73860530a14c608f410b91c6c341777bfa85d upstream
> > does mention it is applicable to v4.4+,
> >
> > Cc: stable@vger.kernel.org # v4.4+
> >
> > but it doesn't have 'Fixes ...' line.
> >
> > What is the best format of a commit message to help to prevent this
> > incident happen again?
>
> You did it right, I missed it when I was applying patches, sorry, my
> fault.
No worries. I guess every maintainer has their automation setup, so just
wanted to check if there is anything in patch submission could be done
better.
Regards,
-Bin.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-20 19:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-20 10:34 Patch "[PATCH] Revert "usb: musb: fix tx fifo flush handling again"" has been added to the 3.18-stable tree gregkh
2017-09-20 13:20 ` Bin Liu
2017-09-20 14:58 ` Greg KH
2017-09-20 19:19 ` Bin Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).