stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: "rafael@kernel.org" <rafael@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"Usyskin, Alexander" <alexander.usyskin@intel.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [char-misc 1/2] mei: always use domain runtime pm callbacks.
Date: Mon, 25 Sep 2017 06:16:33 +0000	[thread overview]
Message-ID: <1506319914.18468.1.camel@intel.com> (raw)
In-Reply-To: <CAJZ5v0h=qTtMb35hbEgvb3UkWjL4gnfBNqjKaLqnz5t+kAaaTw@mail.gmail.com>

	On Mon, 2017-09-25 at 00:37 +0200, Rafael J. Wysocki wrote:
> On Sun, Sep 24, 2017 at 10:35 AM, Tomas Winkler <tomas.winkler@intel.com> wrote:
> > From: Alexander Usyskin <alexander.usyskin@intel.com>
> > 
> > This patch fixes a regression caused by the new changes
> > in the run wake handlers, pci_dev_run_wake() return true
> > when wake is possible from the software perspective
> > not whether it is actually enabled.
> 
> This isn't exactly accurate, because "run wake" used to mean "wakeup
> signals can be generated for this device in the working state of the
> system", so it could not be enabled or disabled before too.  It's just
> that the function returns "true" for (at least) some devices for which
> it used to return "false" (arguably incorrectly).
> 
> Other than that I agree with the patch.

Thanks for the correction, I will respin the patch with your
explanation.

Thanks
Tomas

      reply	other threads:[~2017-09-25  6:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170924083534.20394-1-tomas.winkler@intel.com>
2017-09-24  8:35 ` [char-misc 1/2] mei: always use domain runtime pm callbacks Tomas Winkler
2017-09-24 22:37   ` Rafael J. Wysocki
2017-09-25  6:16     ` Winkler, Tomas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506319914.18468.1.camel@intel.com \
    --to=tomas.winkler@intel.com \
    --cc=alexander.usyskin@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).