From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:54718 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbdJBLnF (ORCPT ); Mon, 2 Oct 2017 07:43:05 -0400 Subject: Patch "SMB3: Warn user if trying to sign connection that authenticated as guest" has been added to the 4.13-stable tree To: smfrench@gmail.com, gregkh@linuxfoundation.org, lsahlber@redhat.com Cc: , From: Date: Mon, 02 Oct 2017 13:42:47 +0200 Message-ID: <1506944567205206@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled SMB3: Warn user if trying to sign connection that authenticated as guest to the 4.13-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: smb3-warn-user-if-trying-to-sign-connection-that-authenticated-as-guest.patch and it can be found in the queue-4.13 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From c721c38957fb19982416f6be71aae7b30630d83b Mon Sep 17 00:00:00 2001 From: Steve French Date: Tue, 19 Sep 2017 18:40:03 -0500 Subject: SMB3: Warn user if trying to sign connection that authenticated as guest From: Steve French commit c721c38957fb19982416f6be71aae7b30630d83b upstream. It can be confusing if user ends up authenticated as guest but they requested signing (server will return error validating signed packets) so add log message for this. Signed-off-by: Steve French Reviewed-by: Ronnie Sahlberg Signed-off-by: Greg Kroah-Hartman --- fs/cifs/smb2pdu.c | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -1164,6 +1164,8 @@ SMB2_sess_setup(const unsigned int xid, while (sess_data->func) sess_data->func(sess_data); + if ((ses->session_flags & SMB2_SESSION_FLAG_IS_GUEST) && (ses->sign)) + cifs_dbg(VFS, "signing requested but authenticated as guest\n"); rc = sess_data->result; out: kfree(sess_data); Patches currently in stable-queue which might be from smfrench@gmail.com are queue-4.13/cifs-release-cifs-root_cred-after-exit_cifs.patch queue-4.13/smb3-warn-user-if-trying-to-sign-connection-that-authenticated-as-guest.patch queue-4.13/smb3-handle-new-statx-fields.patch queue-4.13/smb3-add-support-for-multidialect-negotiate-smb2.1-and-later.patch queue-4.13/smb3-don-t-ignore-o_sync-o_dsync-and-o_direct-flags.patch queue-4.13/fix-smb3.1.1-guest-authentication-to-samba.patch queue-4.13/cifs-release-auth_key.response-for-reconnect.patch queue-4.13/smb3-fix-endian-warning.patch queue-4.13/smb-validate-negotiate-to-protect-against-downgrade-even-if-signing-off.patch queue-4.13/cifs-check-rsp-for-null-before-dereferencing-in-smb2_open.patch