From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39872 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751409AbdJEJCi (ORCPT ); Thu, 5 Oct 2017 05:02:38 -0400 Subject: Patch "IB/ipoib: rtnl_unlock can not come after free_netdev" has been added to the 3.18-stable tree To: ferasda@mellanox.com, alexander.levin@verizon.com, dledford@redhat.com, erezsh@mellanox.com, gregkh@linuxfoundation.org, leon@kernel.org, ogerlitz@mellanox.com, yuval.shaia@oracle.com Cc: , From: Date: Thu, 05 Oct 2017 11:02:34 +0200 Message-ID: <150719415419226@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled IB/ipoib: rtnl_unlock can not come after free_netdev to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ib-ipoib-rtnl_unlock-can-not-come-after-free_netdev.patch and it can be found in the queue-3.18 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From foo@baz Thu Oct 5 10:58:04 CEST 2017 From: Feras Daoud Date: Wed, 28 Dec 2016 14:47:24 +0200 Subject: IB/ipoib: rtnl_unlock can not come after free_netdev From: Feras Daoud [ Upstream commit 89a3987ab7a923c047c6dec008e60ad6f41fac22 ] The ipoib_vlan_add function calls rtnl_unlock after free_netdev, rtnl_unlock not only releases the lock, but also calls netdev_run_todo. The latter function browses the net_todo_list array and completes the unregistration of all its net_device instances. If we call free_netdev before rtnl_unlock, then netdev_run_todo call over the freed device causes panic. To fix, move rtnl_unlock call before free_netdev call. Fixes: 9baa0b036410 ("IB/ipoib: Add rtnl_link_ops support") Cc: Or Gerlitz Signed-off-by: Feras Daoud Signed-off-by: Erez Shitrit Reviewed-by: Yuval Shaia Signed-off-by: Leon Romanovsky Signed-off-by: Doug Ledford Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/ulp/ipoib/ipoib_vlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/infiniband/ulp/ipoib/ipoib_vlan.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_vlan.c @@ -162,11 +162,11 @@ int ipoib_vlan_add(struct net_device *pd out: up_write(&ppriv->vlan_rwsem); + rtnl_unlock(); + if (result) free_netdev(priv->dev); - rtnl_unlock(); - return result; } Patches currently in stable-queue which might be from ferasda@mellanox.com are queue-3.18/ib-ipoib-replace-list_del-of-the-neigh-list-with-list_del_init.patch queue-3.18/ib-ipoib-rtnl_unlock-can-not-come-after-free_netdev.patch queue-3.18/ib-ipoib-fix-deadlock-over-vlan_mutex.patch