From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from smtprelay0138.hostedemail.com ([216.40.44.138]:49362 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1752888AbdJFJJS (ORCPT
        <rfc822;stable@vger.kernel.org>); Fri, 6 Oct 2017 05:09:18 -0400
Message-ID: <1507280954.4434.57.camel@perches.com>
Subject: Re: [PATCH 4.4 22/50] pinctrl: mvebu: Use seq_puts() in
 mvebu_pinconf_group_dbg_show()
From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org,
        Markus Elfring <elfring@users.sourceforge.net>,
        Linus Walleij <linus.walleij@linaro.org>,
        Sasha Levin <alexander.levin@verizon.com>
Date: Fri, 06 Oct 2017 02:09:14 -0700
In-Reply-To: <20171006083708.720505814@linuxfoundation.org>
References: <20171006083705.157012217@linuxfoundation.org>
         <20171006083708.720505814@linuxfoundation.org>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Fri, 2017-10-06 at 10:53 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.

I hope this patch is just to make porting some other patch easier.

Otherwise, this has no place in stable as it has no change in
functionality and is a completely trivial savings in cpu only.


> ------------------
> 
> From: Markus Elfring <elfring@users.sourceforge.net>
> 
> 
> [ Upstream commit 420dc61642920849d824a0de2aa853db59f5244f ]
> 
> Strings which did not contain data format specifications should be put
> into a sequence. Thus use the corresponding function "seq_puts".
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/pinctrl/mvebu/pinctrl-mvebu.c |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> --- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
> @@ -195,11 +195,12 @@ static void mvebu_pinconf_group_dbg_show
>  				seq_printf(s, "o");
>  			seq_printf(s, ")");
>  		}
> -	} else
> -		seq_printf(s, "current: UNKNOWN");
> +	} else {
> +		seq_puts(s, "current: UNKNOWN");
> +	}
>  
>  	if (grp->num_settings > 1) {
> -		seq_printf(s, ", available = [");
> +		seq_puts(s, ", available = [");
>  		for (n = 0; n < grp->num_settings; n++) {
>  			if (curr == &grp->settings[n])
>  				continue;
> @@ -222,7 +223,7 @@ static void mvebu_pinconf_group_dbg_show
>  				seq_printf(s, ")");
>  			}
>  		}
> -		seq_printf(s, " ]");
> +		seq_puts(s, " ]");
>  	}
>  	return;
>  }
> 
>