From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:60668 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308AbdJHU52 (ORCPT ); Sun, 8 Oct 2017 16:57:28 -0400 Message-ID: <1507496237.2677.92.camel@decadent.org.uk> Subject: Re: [PATCH] Btrfs: don't use src fd for printk From: Ben Hutchings To: Jeff Mahoney , stable@vger.kernel.org Cc: David Sterba Date: Sun, 08 Oct 2017 21:57:17 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-doWfa3NnZQBoFoQb6fOJ" Mime-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: --=-doWfa3NnZQBoFoQb6fOJ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-05-17 at 09:36 -0400, Jeff Mahoney wrote: > From: Josef Bacik >=20 > [ Upstream commit c79b4713304f812d3d6c95826fc3e5fc2c0b0c14 ] >=20 > The fd we pass in may not be on a btrfs file system, so don't try to do > BTRFS_I() on it. Thanks, >=20 > Signed-off-by: Josef Bacik > Reviewed-by: David Sterba > Signed-off-by: David Sterba > Cc: stable@vger.kernel.org # 3.14+ Belatedly queued up for 3.16, thanks. Ben. > --- > fs/btrfs/ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c > index 053e677..21423dd 100644 > --- a/fs/btrfs/ioctl.c > +++ b/fs/btrfs/ioctl.c > @@ -1654,7 +1654,7 @@ static noinline int btrfs_ioctl_snap_create_transid= (struct file *file, > =20 > src_inode =3D file_inode(src.file); > if (src_inode->i_sb !=3D file_inode(file)->i_sb) { > - btrfs_info(BTRFS_I(src_inode)->root->fs_info, > + btrfs_info(BTRFS_I(file_inode(file))->root->fs_info, > "Snapshot src from another FS"); > ret =3D -EXDEV; > } else if (!inode_owner_or_capable(src_inode)) { >=20 >=20 > -- > To unsubscribe from this list: send the line "unsubscribe stable" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --=20 Ben Hutchings compatible: Gracefully accepts erroneous data from any source --=-doWfa3NnZQBoFoQb6fOJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAlnakS0ACgkQ57/I7JWG EQnMtxAAnqzScGjHCzC9gpbOTLvQo0XlwgbexgXYCH6FPoEqtRPJR0SHbR7T+iJd MnTPGfN8cGpG5VL9sJrgoIWm3GNbQUMiTvqP/cz5VGRpnC1PJL8yIhN6JmGDPu3j TlVujK0F/LGoK/RFu2DEx3xazzPuNe3DsgGIqxJc01Fhbw/Q15ld7WFjO6pSgmgc FzBGqVlV7PI2UJxPANkA9pAiZ83O3YW6kwf0YigjHXSf3RhWW8psBrOjI4JGw6x6 JHTjB11IEoLVGZvUMd7oQ+EYoMikWHdllTaDROfWIZ5aOjlrGHSzPUS59o8/QlyA 5Fuqtx8r7NllKGu/DvHk7aRKWOHpHzIYRH/tXSrFIxhgVG5JqsoxK4QYqCSRDCYu HaS8lBG8GLbxpF5c7uXRzdwxy28odqus2DdU2hDgUSoH0tRDmiTi7s7nZoju8NC9 bJhYuDUYxarDIkr1XTYvuxy6tY8tFdwKVmG1XqlOxNTBzHws93hF+GylgpPl8Fsm orOky9YepxCz/S6B/2eNBHbRdPxEaURLu3PLljL2OPzC6y9SHaURk88pkiTH5S14 uOEH66UzhhUpYNUnTzXSFp2Yb46S+H/1miTYXl9loAIIZGc++mMUXCgkQCgNGkah lRPzx4tFfN9LAIjOfot9YjuI6mLdDHm1XD+JZb/BY5+BveQ4jnk= =ieFH -----END PGP SIGNATURE----- --=-doWfa3NnZQBoFoQb6fOJ--