From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from imap1.codethink.co.uk ([176.9.8.82]:54904 "EHLO
        imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751906AbdJLRJH (ORCPT
        <rfc822;stable@vger.kernel.org>); Thu, 12 Oct 2017 13:09:07 -0400
Message-ID: <1507828137.22379.3.camel@codethink.co.uk>
Subject: Re: [PATCH 4.9 000/105] 4.9.55-stable review
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Shuah Khan <shuahkh@osg.samsung.com>,
        Xin Long <lucien.xin@gmail.com>,
        Andreas Radke <andreas.radke@mailbox.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        LKML <linux-kernel@vger.kernel.org>,
        torvalds@linux-foundation.org, akpm@linux-foundation.org,
        linux@roeck-us.net, patches@kernelci.org, stable@vger.kernel.org
Date: Thu, 12 Oct 2017 18:08:57 +0100
In-Reply-To: <87b44ea3-e614-7461-3b53-2da61f40a320@osg.samsung.com>
References: <20171010192533.717049376@linuxfoundation.org>
         <f7e165f3-dd26-7a09-73eb-3dd134abbb2e@osg.samsung.com>
         <20171011125646.GG27734@kroah.com>
         <10022e69-2644-cd2c-4abf-643fb53115fd@osg.samsung.com>
         <20171012103952.GE24647@kroah.com> <20171012115426.GA25954@kroah.com>
         <20171012121316.GA12343@kroah.com>
         <97b732a2-c7a2-e1db-407f-1158bba663a7@osg.samsung.com>
         <CADvbK_dTji3wdKM_31DGMvUNYiArUv--PkZBO8Fxnatp=fxJ-w@mail.gmail.com>
         <20171012171826.122420ea@workstation64.home>
         <CADvbK_eDqUG5+eKpBreVtkDR1nNik327aNsz-rbf4jE7YmjAig@mail.gmail.com>
         <f3052fa1-f99f-10e6-4a73-8db749aa4e51@osg.samsung.com>
         <87b44ea3-e614-7461-3b53-2da61f40a320@osg.samsung.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, 2017-10-12 at 10:54 -0600, Shuah Khan wrote:
> On 10/12/2017 09:35 AM, Shuah Khan wrote:
> > On 10/12/2017 09:25 AM, Xin Long wrote:
> > > On Thu, Oct 12, 2017 at 11:18 PM, Andreas Radke
> > > <andreas.radke@mailbox.org> wrote:
> > > > Building the 4.9.x kernel package for Arch Linux 4.9.55 gives
> > > > this IPv4 error here:
[...]
> > > > Okt 12 17:09:38 server64 dhcpd[638]: Can't install packet
> > > > filter program: Cannot allocate memory
[...]
> > > pls try revert:
> > > commit 02f7e4101092b88e57c73171174976c8a72a3eba
> > 
> > Correction. The commit is:
> > 
> > 345c66695569db83eed100723e4df72cb54df7de
> > 
> > I will try the revert and let you know.
> 
> okay reverting the
> 
> commit 345c66695569db83eed100723e4df72cb54df7de
> Author: Eric Dumazet <edumazet@google.com>
> Date:   Mon Oct 2 12:20:51 2017 -0700
> 
>     socket, bpf: fix possible use after free
>     
>     
>     [ Upstream commit eefca20eb20c66b06cf5ed09b49b1a7caaa27b7b ]
[...]
> fixes the issue. Looks like this is a fix for another problem.

It seems to depend on:

commit 4c355cdfbba537971b5c3849680b1b6453a7a383
Author: Reshetova, Elena <elena.reshetova@intel.com>
Date:   Tue Mar 21 13:59:19 2017 +0200

    net: convert sk_filter.refcnt from atomic_t to refcount_t

That split up sk_filter_charge() so that the refcount initialisation
won't trip the increment-from-zero check.

Ben.

> Anyway - I have 4.9.55 - minus
> 345c66695569db83eed100723e4df72cb54df7de
> running now with networking operational.
> 
> thanks,
> -- Shuah
> 
> 
> 
-- 
Ben Hutchings
Software Developer, Codethink Ltd.